Skip to content

[dsymutil] Fix whitespace issues and typo in HelpText. #108310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

rjmansfield
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Sep 12, 2024

@llvm/pr-subscribers-debuginfo

Author: None (rjmansfield)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/108310.diff

1 Files Affected:

  • (modified) llvm/tools/dsymutil/Options.td (+7-7)
diff --git a/llvm/tools/dsymutil/Options.td b/llvm/tools/dsymutil/Options.td
index b72ae1909a7274..67d367565764f4 100644
--- a/llvm/tools/dsymutil/Options.td
+++ b/llvm/tools/dsymutil/Options.td
@@ -129,18 +129,18 @@ def: Joined<["--", "-"], "oso-prepend-path=">, Alias<oso_prepend_path>;
 
 def object_prefix_map: Separate<["--", "-"], "object-prefix-map">,
     MetaVarName<"<prefix=remapped>">,
-    HelpText<"Remap object file paths (but no source paths) before processing."
-             "Use this for Clang objects where the module cache location was"
-             "remapped using -fdebug-prefix-map; to help dsymutil"
+    HelpText<"Remap object file paths (but no source paths) before processing. "
+             "Use this for Clang objects where the module cache location was "
+             "remapped using -fdebug-prefix-map; to help dsymutil "
              "find the Clang module cache.">,
     Group<grp_general>;
 def: Joined<["--", "-"], "object-prefix-map=">, Alias<object_prefix_map>;
 
 def arch: Separate<["--", "-"], "arch">,
   MetaVarName<"<arch>">,
-  HelpText<"Link DWARF debug information only for specified CPU architecture"
-           "types. This option can be specified multiple times, once for each"
-           "desired architecture. All CPU architectures will be linked by"
+  HelpText<"Link DWARF debug information only for specified CPU architecture "
+           "types. This option can be specified multiple times, once for each "
+           "desired architecture. All CPU architectures will be linked by "
            "default.">,
   Group<grp_general>;
 def: Joined<["--", "-"], "arch=">, Alias<arch>;
@@ -206,7 +206,7 @@ def: Joined<["--", "-"], "linker=">, Alias<linker>;
 
 def build_variant_suffix: Separate<["--", "-"], "build-variant-suffix">,
   MetaVarName<"<suffix=buildvariant>">,
-  HelpText<"Specify the build variant suffix used to build the executabe file.">,
+  HelpText<"Specify the build variant suffix used to build the executable file.">,
   Group<grp_general>;
 def: Joined<["--", "-"], "build-variant-suffix=">, Alias<build_variant_suffix>;
 

@zimirza
Copy link
Contributor

zimirza commented Sep 12, 2024

Wouldn't removing the whitespaces combine the words? I think these are string concatenation.

@rjmansfield
Copy link
Contributor Author

I believe you're reading the diff backwards.

@zimirza
Copy link
Contributor

zimirza commented Sep 12, 2024

Yes, you are correct. Sorry about that.

@rjmansfield
Copy link
Contributor Author

Could someone with commit access merge on my behalf? Thanks.

@jryans jryans merged commit 229f391 into llvm:main Sep 12, 2024
10 checks passed
@rjmansfield rjmansfield deleted the dsymutil-helptext branch September 12, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants