[TableGen] Remove duplicate code in applyMnemonicAliases when target uses DefaultAsmParserVariant. #108494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uses DefaultAsmParserVariant. The DefaultAsmParserVariant has an empty name. MnemonicAliases use an empty string to mean the aliases applies to all variants. Targets that uses DefaultAsmParserVariant were emitting the same code inside the variant loop and after the variant loop because an empty string got passed to emitMnemonicAliasVariant in both places. This patch detects the empty variant name in the loop and skips the emission.
arsenm
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DefaultAsmParserVarianthas an empty name.MnemonicAliasuses an empty string to mean the aliases applies to all variants.Targets that uses
DefaultAsmParserVariantwere emitting the same code inside the variant loop and after the variant loop because an empty string got passed toemitMnemonicAliasVariantin both places.This patch detects the empty variant name in the loop and skips the emission.