Skip to content

[AMDGPU][NewPM] Fill out addILPOpts. #108514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

cdevadas
Copy link
Collaborator

No description provided.

Copy link
Collaborator Author

cdevadas commented Sep 13, 2024

@llvmbot
Copy link
Member

llvmbot commented Sep 13, 2024

@llvm/pr-subscribers-backend-amdgpu

Author: Christudasan Devadasan (cdevadas)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/108514.diff

2 Files Affected:

  • (modified) llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp (+7)
  • (modified) llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h (+1)
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp b/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
index 8c45e6b5e589c2..6cc9ff6a981fee 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
@@ -1898,6 +1898,13 @@ void AMDGPUCodeGenPassBuilder::addPreISel(AddIRPass &addPass) const {
   addPass(RequireAnalysisPass<UniformityInfoAnalysis, Function>());
 }
 
+void AMDGPUCodeGenPassBuilder::addILPOpts(AddMachinePass &addPass) const {
+  if (EnableEarlyIfConversion)
+    addPass(EarlyIfConverterPass());
+
+  Base::addILPOpts(addPass);
+}
+
 void AMDGPUCodeGenPassBuilder::addAsmPrinter(AddMachinePass &addPass,
                                              CreateMCStreamer) const {
   // TODO: Add AsmPrinter.
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h b/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h
index 5b7257ddb36f1e..96b414f294ee70 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h
+++ b/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h
@@ -172,6 +172,7 @@ class AMDGPUCodeGenPassBuilder
   void addIRPasses(AddIRPass &) const;
   void addCodeGenPrepare(AddIRPass &) const;
   void addPreISel(AddIRPass &addPass) const;
+  void addILPOpts(AddMachinePass &) const;
   void addAsmPrinter(AddMachinePass &, CreateMCStreamer) const;
   Error addInstSelector(AddMachinePass &) const;
 

@cdevadas cdevadas force-pushed the users/cdevadas/port-early-if-converter-to-npm branch from 8d0f406 to 5a362f4 Compare October 15, 2024 08:23
@cdevadas cdevadas force-pushed the users/cdevadas/fill-add-ilp-opts branch from 2941048 to 0be0bb7 Compare October 15, 2024 08:24
@cdevadas cdevadas force-pushed the users/cdevadas/port-early-if-converter-to-npm branch from 5a362f4 to 500cd0a Compare October 15, 2024 08:52
@cdevadas cdevadas force-pushed the users/cdevadas/fill-add-ilp-opts branch from 0be0bb7 to 10462c6 Compare October 15, 2024 08:52
@cdevadas cdevadas force-pushed the users/cdevadas/port-early-if-converter-to-npm branch from 500cd0a to 663c681 Compare October 15, 2024 16:38
@cdevadas cdevadas force-pushed the users/cdevadas/fill-add-ilp-opts branch from 10462c6 to 037b151 Compare October 15, 2024 16:38
Copy link
Collaborator Author

cdevadas commented Oct 16, 2024

Merge activity

  • Oct 16, 3:38 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 16, 3:53 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 16, 3:58 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 16, 4:00 AM EDT: A user merged this pull request with Graphite.

@cdevadas cdevadas force-pushed the users/cdevadas/port-early-if-converter-to-npm branch from 663c681 to ea1940e Compare October 16, 2024 07:50
Base automatically changed from users/cdevadas/port-early-if-converter-to-npm to main October 16, 2024 07:52
@cdevadas cdevadas force-pushed the users/cdevadas/fill-add-ilp-opts branch from 037b151 to ce2b9ab Compare October 16, 2024 07:53
@cdevadas cdevadas force-pushed the users/cdevadas/fill-add-ilp-opts branch from ce2b9ab to b48ed9b Compare October 16, 2024 07:57
@cdevadas cdevadas merged commit 72a7b47 into main Oct 16, 2024
5 of 7 checks passed
@cdevadas cdevadas deleted the users/cdevadas/fill-add-ilp-opts branch October 16, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants