-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[llvm][docs] Document how to get admin permissions for a Buildbot worker #108561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
And if you're wondering, the console output looks like:
I'm not sure why I thought to check it at all, so I figured it was worth mentioning even though it's a bit of an unintended feature. |
I spent a long time trying different combinations of primary and verified emails, until a colleague tried it who happened to have a public profile email set when I did not. Document how this works to save everyone else the legwork.
6f16928
to
d460e13
Compare
ping! @gkistanova |
ping! Though I know the instructions do work, so I will go ahead and land this if there's no input in the next week. |
…ker (llvm#108561) I spent a long time trying different combinations of primary and verified emails, until a colleague tried it who happened to have a public profile email set when I did not. Document how this works to save everyone else the legwork.
Firstly, thank you for documenting this - I recently had to reach out to Galina for help with this, but I failed to think to follow up to document it. I know it's post-commit, but two thoughts:
|
The key point here is that Buildbot sees the email listed on your public GitHub profile page. That email must therefore be associated with the account, but it can be primary or secondary, as long as you've chosen to show it on your profile. I see you have This is what had me stuck for ages, it was only by chance a colleague interpreted "GitHub email" to mean "GitHub profile email" and we realised what was happening. That said, if that's not clear I'll update the wording. |
You know I think this is the key reason for my confusion, because when you login and grant oauth permissions to the buildbot it requests permission to "Access user email addresses (read-only)". ie. the user:email permission here which should allow listing all email addresses https://docs.github.com/en/rest/users/emails?apiVersion=2022-11-28#list-email-addresses-for-the-authenticated-user |
I spent a long time trying different combinations of primary and verified emails, until a colleague tried it who happened to have a public profile email set when I did not.
Document how this works to save everyone else the legwork.