Skip to content

[RISCV] Change Zvbb and Zvkb from 'Assembly Support' to Supported. #108572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

topperc
Copy link
Collaborator

@topperc topperc commented Sep 13, 2024

We have generic isel support for Zvkb and Zvbb.

We have generic isel support for Zvkb and Zvbb.
@llvmbot
Copy link
Member

llvmbot commented Sep 13, 2024

@llvm/pr-subscribers-backend-risc-v

Author: Craig Topper (topperc)

Changes

We have generic isel support for Zvkb and Zvbb.


Full diff: https://github.com/llvm/llvm-project/pull/108572.diff

1 Files Affected:

  • (modified) llvm/docs/RISCVUsage.rst (+2-2)
diff --git a/llvm/docs/RISCVUsage.rst b/llvm/docs/RISCVUsage.rst
index a15af9adfa945a..cf52cd15228477 100644
--- a/llvm/docs/RISCVUsage.rst
+++ b/llvm/docs/RISCVUsage.rst
@@ -207,7 +207,7 @@ on support follow.
      ``Zkt``           Supported
      ``Zmmul``         Supported
      ``Ztso``          Supported
-     ``Zvbb``          Assembly Support
+     ``Zvbb``          Supported
      ``Zvbc``          Assembly Support
      ``Zve32x``        (`Partially <#riscv-vlen-32-note>`__) Supported
      ``Zve32f``        (`Partially <#riscv-vlen-32-note>`__) Supported
@@ -217,7 +217,7 @@ on support follow.
      ``Zvfbfmin``      Supported
      ``Zvfbfwma``      Supported
      ``Zvfh``          Supported
-     ``Zvkb``          Assembly Support
+     ``Zvkb``          Suppported
      ``Zvkg``          Assembly Support
      ``Zvkn``          Assembly Support
      ``Zvknc``         Assembly Support

Copy link
Collaborator

@preames preames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Last I checked we only used these in a subset of cases we could, but yes, we have some codegen support.

Copy link
Member

@4vtomat 4vtomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@topperc topperc merged commit 8e2843b into llvm:main Sep 13, 2024
11 checks passed
@topperc topperc deleted the pr/zvkb-zvbb-doc-fix branch September 13, 2024 16:29
@topperc topperc restored the pr/zvkb-zvbb-doc-fix branch September 13, 2024 16:29
@topperc topperc deleted the pr/zvkb-zvbb-doc-fix branch September 13, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants