Skip to content

[NFC][DirectX] Remove rcp dx intrinsic #108626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

farzonl
Copy link
Member

@farzonl farzonl commented Sep 13, 2024

The code that used the rcp intrinsic was replaced. This change removes an unused intrinsic.

The code that used the rcp intrinsic was replaced. This change removes an unused intrinsic.
@farzonl farzonl marked this pull request as ready for review September 13, 2024 18:56
@llvmbot
Copy link
Member

llvmbot commented Sep 13, 2024

@llvm/pr-subscribers-llvm-ir

@llvm/pr-subscribers-backend-directx

Author: Farzon Lotfi (farzonl)

Changes

The code that used the rcp intrinsic was replaced. This change removes an unused intrinsic.


Full diff: https://github.com/llvm/llvm-project/pull/108626.diff

1 Files Affected:

  • (modified) llvm/include/llvm/IR/IntrinsicsDirectX.td (-1)
diff --git a/llvm/include/llvm/IR/IntrinsicsDirectX.td b/llvm/include/llvm/IR/IntrinsicsDirectX.td
index f1017bdd512496..0cbff019829693 100644
--- a/llvm/include/llvm/IR/IntrinsicsDirectX.td
+++ b/llvm/include/llvm/IR/IntrinsicsDirectX.td
@@ -85,7 +85,6 @@ def int_dx_length : DefaultAttrsIntrinsic<[LLVMVectorElementType<0>], [llvm_anyf
 def int_dx_imad : DefaultAttrsIntrinsic<[llvm_anyint_ty], [LLVMMatchType<0>, LLVMMatchType<0>, LLVMMatchType<0>]>;
 def int_dx_umad : DefaultAttrsIntrinsic<[llvm_anyint_ty], [LLVMMatchType<0>, LLVMMatchType<0>, LLVMMatchType<0>]>;
 def int_dx_normalize : DefaultAttrsIntrinsic<[LLVMMatchType<0>], [llvm_anyfloat_ty]>;
-def int_dx_rcp  : DefaultAttrsIntrinsic<[llvm_anyfloat_ty], [LLVMMatchType<0>]>;
 def int_dx_rsqrt  : DefaultAttrsIntrinsic<[llvm_anyfloat_ty], [LLVMMatchType<0>]>;
 
 def int_dx_wave_is_first_lane : DefaultAttrsIntrinsic<[llvm_i1_ty], [], [IntrConvergent]>;

@farzonl farzonl changed the title [DirectX] Remove rcp dx intrinsic [NFC][DirectX] Remove rcp dx intrinsic Sep 13, 2024
Copy link

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

@farzonl farzonl merged commit 52b3c36 into llvm:main Sep 14, 2024
13 checks passed
@farzonl farzonl deleted the remove-rcp-dx-intrinsic branch September 24, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants