Skip to content

[mlir][affine] Verify map of affineMaxMinOp has at least one result #108699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mlir/lib/Dialect/Affine/IR/AffineOps.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3214,6 +3214,9 @@ static LogicalResult verifyAffineMinMaxOp(T op) {
op.getMap().getNumDims() + op.getMap().getNumSymbols())
return op.emitOpError(
"operand count and affine map dimension and symbol count must match");

if (op.getMap().getNumResults() == 0)
return op.emitOpError("affine map expect at least one result");
return success();
}

Expand Down
32 changes: 32 additions & 0 deletions mlir/test/Dialect/Affine/invalid.mlir
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,22 @@ func.func @affine_min(%arg0 : index, %arg1 : index, %arg2 : index) {

// -----

func.func @affine_min() {
// expected-error@+1 {{'affine.min' op affine map expect at least one result}}
%0 = affine.min affine_map<() -> ()> ()
return
}

// -----

func.func @affine_min(%arg0 : index) {
// expected-error@+1 {{'affine.min' op affine map expect at least one result}}
%0 = affine.min affine_map<(d0) -> ()> (%arg0)
return
}

// -----

func.func @affine_max(%arg0 : index, %arg1 : index, %arg2 : index) {
// expected-error@+1 {{operand count and affine map dimension and symbol count must match}}
%0 = affine.max affine_map<(d0) -> (d0)> (%arg0, %arg1)
Expand Down Expand Up @@ -205,6 +221,22 @@ func.func @affine_max(%arg0 : index, %arg1 : index, %arg2 : index) {

// -----

func.func @affine_max() {
// expected-error@+1 {{'affine.max' op affine map expect at least one result}}
%0 = affine.max affine_map<() -> ()> ()
return
}

// -----

func.func @affine_max(%arg0 : index) {
// expected-error@+1 {{'affine.max' op affine map expect at least one result}}
%0 = affine.max affine_map<(d0) -> ()> (%arg0)
return
}

// -----

func.func @affine_parallel(%arg0 : index, %arg1 : index, %arg2 : index) {
// expected-error@+1 {{the number of region arguments (1) and the number of map groups for lower (2) and upper bound (2), and the number of steps (2) must all match}}
affine.parallel (%i) = (0, 0) to (100, 100) step (10, 10) {
Expand Down
Loading