Skip to content

[NFC] Correct the misuse of the API in the Clang test-report script. #108725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

c8ef
Copy link
Contributor

@c8ef c8ef commented Sep 15, 2024

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Sep 15, 2024
@llvmbot
Copy link
Member

llvmbot commented Sep 15, 2024

@llvm/pr-subscribers-clang

Author: None (c8ef)

Changes

ref: https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertEqual


Full diff: https://github.com/llvm/llvm-project/pull/108725.diff

1 Files Affected:

  • (modified) clang/tools/scan-build-py/tests/unit/test_report.py (+1-1)
diff --git a/clang/tools/scan-build-py/tests/unit/test_report.py b/clang/tools/scan-build-py/tests/unit/test_report.py
index 4d85590a211229..88dcb965d0da34 100644
--- a/clang/tools/scan-build-py/tests/unit/test_report.py
+++ b/clang/tools/scan-build-py/tests/unit/test_report.py
@@ -538,7 +538,7 @@ def test_merge_updates_embedded_link(self):
                         "test message 6-1 [link](sarif:/runs/4/results/0)",
                     ],
                 )
-                self.assertEquals(
+                self.assertEqual(
                     thread_flows,
                     [
                         "test message 1-2 [link](sarif:/runs/1/results/0)",

@c8ef
Copy link
Contributor Author

c8ef commented Sep 17, 2024

Hi @tru, could you please take a look at this patch?

@c8ef
Copy link
Contributor Author

c8ef commented Sep 27, 2024

Hi @nikic,

Could you please help me review this patch? It shares the same origin as #107030, so hopefully, it won't take much time to review.

Thanks!

Copy link
Collaborator

@tru tru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c8ef
Copy link
Contributor Author

c8ef commented Sep 29, 2024

Hi @tru @nikic, if the patch looks good to you, could you please land it for me? Thanks!

@nikic nikic merged commit 2e559c3 into llvm:main Oct 1, 2024
10 checks passed
@c8ef c8ef deleted the patch-1 branch October 1, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants