Skip to content

[WebAssembly] Fix .functype directives in tests #108748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2024
Merged

[WebAssembly] Fix .functype directives in tests #108748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c65a35a
[WebAssembly] Fix .functype directives in tests
aheejin Sep 15, 2024
91ab163
Merge branch 'main' into functype
aheejin Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions llvm/test/MC/WebAssembly/eh-assembly-legacy.s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@

.tagtype __cpp_exception i32
.tagtype __c_longjmp i32
.functype eh_legacy_test () -> ()
.functype foo () -> ()

eh_legacy_test:
.functype eh_legacy_test () -> ()

# try-catch with catch, catch_all, throw, and rethrow
try
i32.const 3
Expand Down Expand Up @@ -55,7 +56,7 @@ eh_legacy_test:
end_function

# CHECK-LABEL: eh_legacy_test:
# CHECK-NEXT: try
# CHECK: try
# CHECK-NEXT: i32.const 3
# CHECK-NEXT: throw __cpp_exception
# CHECK-NEXT: catch __cpp_exception
Expand Down
10 changes: 5 additions & 5 deletions llvm/test/MC/WebAssembly/func-end-errors.s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@
# assembly. This causes the parser to properly wrap up function info when there
# is no other instructions present.

.functype test0 () -> ()
test0:
.functype test0 () -> ()

.functype test1 () -> ()
# CHECK: [[@LINE+1]]:1: error: Unmatched block construct(s) at function end: function
test1:
# CHECK: [[@LINE+1]]:{{.*}}: error: Unmatched block construct(s) at function end: function
.functype test1 () -> ()
end_function

.functype test2 () -> ()
test2:
# CHECK: [[@LINE+1]]:1: error: Unmatched block construct(s) at function end: function
.functype test2 () -> ()
# CHECK: [[@LINE+1]]:{{.*}}: error: Unmatched block construct(s) at function end: function
2 changes: 1 addition & 1 deletion llvm/test/MC/WebAssembly/funcref-from-table.s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
.globl obtain_funcref_from_table_index

obtain_funcref_from_table_index:
.functype obtain_funcref_from_table_index(i32) -> (funcref)
.functype obtain_funcref_from_table_index (i32) -> (funcref)
local.get 0
table.get __indirect_function_table
end_function
Expand Down
2 changes: 1 addition & 1 deletion llvm/test/MC/WebAssembly/type-checker-br.s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ br_block:
end_function

br_func:
.functype br_block () -> ()
.functype br_func () -> ()
block i32
br 1
i32.const 1
Expand Down
Loading