Skip to content

[VirtRegMap] Remove unused MAX_STACK_SLOT. NFC #108781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

topperc
Copy link
Collaborator

@topperc topperc commented Sep 15, 2024

I think this has been unuesd since 92255f2 in 2011.

I think this has been unuesd since 92255f2
in 2011.
@llvmbot
Copy link
Member

llvmbot commented Sep 15, 2024

@llvm/pr-subscribers-llvm-regalloc

Author: Craig Topper (topperc)

Changes

I think this has been unuesd since 92255f2 in 2011.


Full diff: https://github.com/llvm/llvm-project/pull/108781.diff

1 Files Affected:

  • (modified) llvm/include/llvm/CodeGen/VirtRegMap.h (-1)
diff --git a/llvm/include/llvm/CodeGen/VirtRegMap.h b/llvm/include/llvm/CodeGen/VirtRegMap.h
index 96c28c191e8bd5..dee462255b0b28 100644
--- a/llvm/include/llvm/CodeGen/VirtRegMap.h
+++ b/llvm/include/llvm/CodeGen/VirtRegMap.h
@@ -34,7 +34,6 @@ class TargetInstrInfo;
   public:
     enum {
       NO_STACK_SLOT = (1L << 30)-1,
-      MAX_STACK_SLOT = (1L << 18)-1
     };
 
   private:

Copy link

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff 40e8e4ddcb7d48f404223e863e5db38fff75cad2 bf11b36fae318ee8e21575d8190c3486ef2b7345 --extensions h -- llvm/include/llvm/CodeGen/VirtRegMap.h
View the diff from clang-format here.
diff --git a/llvm/include/llvm/CodeGen/VirtRegMap.h b/llvm/include/llvm/CodeGen/VirtRegMap.h
index dee462255b..1ad181046d 100644
--- a/llvm/include/llvm/CodeGen/VirtRegMap.h
+++ b/llvm/include/llvm/CodeGen/VirtRegMap.h
@@ -33,7 +33,7 @@ class TargetInstrInfo;
   class VirtRegMap : public MachineFunctionPass {
   public:
     enum {
-      NO_STACK_SLOT = (1L << 30)-1,
+      NO_STACK_SLOT = (1L << 30) - 1,
     };
 
   private:

@topperc topperc requested a review from qcolombet September 16, 2024 19:01
@topperc topperc merged commit 78f7aae into llvm:main Sep 17, 2024
9 of 10 checks passed
@topperc topperc deleted the pr/unused-max-stack-slot branch September 17, 2024 15:34
tmsri pushed a commit to tmsri/llvm-project that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants