[docs][clang-tidy] Correct StrictMode example in modernize-use-std-print

[MainakSil]

Updated the example in the StrictMode section of the clang-tidy check modernize-use-std-print.

The previous example incorrectly swapped the cast of signed and unsigned integers. Specifically:

• The signed integer i was being cast to unsigned int, and
• The unsigned integer u was being cast to int.

This correction ensures that the behavior of std::print with StrictMode enabled matches that of printf, by reversing the casts to maintain the correct signedness.

Issue Refference
It solves #101397

[llvmbot]

@llvm/pr-subscribers-clang-tidy

Author: Mainak Sil (MainakSil)

Changes

Updated the example in the StrictMode section of the clang-tidy check modernize-use-std-print.

The previous example incorrectly swapped the cast of signed and unsigned integers. Specifically:

• The signed integer i was being cast to unsigned int, and
• The unsigned integer u was being cast to int.

This correction ensures that the behavior of std::print with StrictMode enabled matches that of printf, by reversing the casts to maintain the correct signedness.

Issue Refference
It solves #101397

---

Full diff: https://github.com/llvm/llvm-project/pull/108805.diff

1 Files Affected:

• (modified) clang-tools-extra/docs/clang-tidy/checks/modernize/use-std-print.rst (+1-1)

diff --git a/clang-tools-extra/docs/clang-tidy/checks/modernize/use-std-print.rst b/clang-tools-extra/docs/clang-tidy/checks/modernize/use-std-print.rst
index 59bb722e2c24fc..a825cd7432a57d 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/modernize/use-std-print.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/modernize/use-std-print.rst
@@ -109,7 +109,7 @@ Options
 
   .. code-block:: c++
 
-    std::print("{} {}\n", static_cast<unsigned int>(i), static_cast<int>(u));
+    std::print("{} {}\n", static_cast<int>(u), static_cast<unsigned int>(i));
 
   to ensure that the output will continue to be the unsigned representation
   of `-42` and the signed representation of `0xffffffff` (often

[llvmbot]

@llvm/pr-subscribers-clang-tools-extra

Author: Mainak Sil (MainakSil)

Changes

Updated the example in the StrictMode section of the clang-tidy check modernize-use-std-print.

The previous example incorrectly swapped the cast of signed and unsigned integers. Specifically:

• The signed integer i was being cast to unsigned int, and
• The unsigned integer u was being cast to int.

This correction ensures that the behavior of std::print with StrictMode enabled matches that of printf, by reversing the casts to maintain the correct signedness.

Issue Refference
It solves #101397

---

Full diff: https://github.com/llvm/llvm-project/pull/108805.diff

1 Files Affected:

• (modified) clang-tools-extra/docs/clang-tidy/checks/modernize/use-std-print.rst (+1-1)

diff --git a/clang-tools-extra/docs/clang-tidy/checks/modernize/use-std-print.rst b/clang-tools-extra/docs/clang-tidy/checks/modernize/use-std-print.rst
index 59bb722e2c24fc..a825cd7432a57d 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/modernize/use-std-print.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/modernize/use-std-print.rst
@@ -109,7 +109,7 @@ Options
 
   .. code-block:: c++
 
-    std::print("{} {}\n", static_cast<unsigned int>(i), static_cast<int>(u));
+    std::print("{} {}\n", static_cast<int>(u), static_cast<unsigned int>(i));
 
   to ensure that the output will continue to be the unsigned representation
   of `-42` and the signed representation of `0xffffffff` (often

[nicovank]

I think the example should be:

printf("%u %d\n", i, u); // Change here.
// transforms to:
std::println("{} {}", static_cast<unsigned int>(i), static_cast<int>(u)); // No change here.

[nicovank]

The arguments shouldn't be swapped, I think the initial code block above must swap the %d and %u specifier for this example to make sense.

[nicovank]

cc @mikecrowe

[MainakSil]

Please check now.

[mikecrowe]

Thanks for fixing this @MainakSil. I wasn't aware of the bug report until now.

@nicovank is correct that only the format string needs to change as I got the format specifiers the wrong way round originally. Thanks for adding me to this change.

I copied the same mistake to use-std-format.rst if you'd like to fix that one too in this change. If not then I will do so.

Thanks.

[MainakSil]

Thanks for pointing that out, @mikecrowe! I've gone ahead and fixed the same mistake in use-std-format.rst as well in this PR.

[mikecrowe]

LGTM. Thanks for fixing this.

[MainakSil]

Please merge it if it looks good to you guys...