update_test_checks: recognize %if in RUN line

[ElvinaYakubova]

Recognize %if for target-specific cases in RUN line and keep only tool command with options

[llvmbot]

@llvm/pr-subscribers-testing-tools

Author: Elvina Yakubova (ElvinaYakubova)

Changes

Recognize %if for target-specific cases in RUN line and keep only tool command with options

---

Full diff: https://github.com/llvm/llvm-project/pull/108972.diff

1 Files Affected:

• (modified) llvm/utils/update_test_checks.py (+7-1)

diff --git a/llvm/utils/update_test_checks.py b/llvm/utils/update_test_checks.py
index 16f3e618770b20..4bcc501f4d04a3 100755
--- a/llvm/utils/update_test_checks.py
+++ b/llvm/utils/update_test_checks.py
@@ -123,7 +123,13 @@ def main():
                 common.warn("Skipping unparsable RUN line: " + l)
                 continue
 
-            commands = [cmd.strip() for cmd in l.split("|")]
+            cropped_content = l
+            if "%if" in l:
+                match = re.search(r'%{\s*(.*?)\s*%}', l)
+                if match:
+                    cropped_content = match.group(1)
+
+            commands = [cmd.strip() for cmd in cropped_content.split("|")]
             assert len(commands) >= 2
             preprocess_cmd = None
             if len(commands) > 2:

[github-actions]

✅ With the latest revision this PR passed the Python code formatter.

[RKSimon]

test case?

[arichardson]

It would be good to move any of this parsing to common so that the other update scripts also benfit from this (cc_test_checks, llc_test_checks, mir_test_checks).

I think the ideal solution would be to reuse lit code parse the RUN lines instead of re-implementing most of the syntax in these scripts. I started working on that a while ago but never got around to finishing it.

[ElvinaYakubova]

test case?

added test case

[ElvinaYakubova]

It would be good to move any of this parsing to common so that the other update scripts also benfit from this (cc_test_checks, llc_test_checks, mir_test_checks).

I think the ideal solution would be to reuse lit code parse the RUN lines instead of re-implementing most of the syntax in these scripts. I started working on that a while ago but never got around to finishing it.

do you have an open PR or branch in your fork repo for that?

[ElvinaYakubova]

gentle ping @RKSimon
Can I merge these changes now, and work on moving parsing to the common level as a separate task?