Skip to content

[libc++][docs][NFC] Fix inline code style - use double backticks #108974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

H-G-Hristov
Copy link
Contributor

This is an apparrent omission. Single backick (Markdown style) was used instead of double backtick for inline code style.

This is an apparrent omission. Single backick (Markdown style) was used instead of double backtick for inline code style.
@H-G-Hristov H-G-Hristov requested a review from a team as a code owner September 17, 2024 13:23
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Sep 17, 2024
@llvmbot
Copy link
Member

llvmbot commented Sep 17, 2024

@llvm/pr-subscribers-libcxx

Author: Hristo Hristov (H-G-Hristov)

Changes

This is an apparrent omission. Single backick (Markdown style) was used instead of double backtick for inline code style.


Full diff: https://github.com/llvm/llvm-project/pull/108974.diff

1 Files Affected:

  • (modified) libcxx/docs/Contributing.rst (+1-1)
diff --git a/libcxx/docs/Contributing.rst b/libcxx/docs/Contributing.rst
index f81c537e00c243..b15fc88943d59b 100644
--- a/libcxx/docs/Contributing.rst
+++ b/libcxx/docs/Contributing.rst
@@ -168,7 +168,7 @@ sure you don't forget anything:
 
 - Did you add the relevant feature test macro(s) for your feature? Did you update the ``generate_feature_test_macro_components.py`` script with it?
 - Did you run the ``libcxx-generate-files`` target and verify its output?
-- If needed, did you add `_LIBCPP_PUSH_MACROS` and `_LIBCPP_POP_MACROS` to the relevant headers?
+- If needed, did you add ``_LIBCPP_PUSH_MACROS`` and ``_LIBCPP_POP_MACROS`` to the relevant headers?
 
 The review process
 ==================

Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ldionne ldionne merged commit 6f5dd65 into llvm:main Sep 17, 2024
9 of 15 checks passed
tmsri pushed a commit to tmsri/llvm-project that referenced this pull request Sep 19, 2024
)

This is an apparrent omission. Single backick (Markdown style) was used
instead of double backtick for inline code style.
@H-G-Hristov H-G-Hristov deleted the hgh/libcxx/Contributing_rst-fixed-style-of-macros branch October 8, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants