[ASan][test] Skip Linux/odr_c_test.c on SPARC #109111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ASan testing is enabled on SPARC as per PR llvm#107405, the ``` AddressSanitizer-sparc-linux :: TestCases/Linux/odr_c_test.c ``` `FAIL`s on Linux/sparc64: ``` + projects/compiler-rt/test/asan/SPARCLinuxConfig/TestCases/Linux/Output/odr_c_test.c.tmp + count 0 Expected 0 lines, got 13. AddressSanitizer:DEADLYSIGNAL ================================================================= ==4165420==ERROR: AddressSanitizer: BUS on unknown address (pc 0x7012d5b4 bp 0xffa3b938 sp 0xffa3b8d0 T0) ==4165420==The signal is caused by a READ memory access. ==4165420==Hint: this fault was caused by a dereference of a high value address (see register values below). Disassemble the provided pc to learn which register was used. ``` The test relies on an unaligned access, which cannot work on a strict-alignment target like SPARC. Thus this patch skips the test. Tested on `sparc64-unknown-linux-gnu`.
llvmbot
added
compiler-rt
compiler-rt:asan
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Rainer Orth (rorth) ChangesWhen ASan testing is enabled on SPARC as per PR #107405, the test The test relies on an unaligned access, which cannot work on a strict-alignment target like SPARC. Thus this patch skips the test. Tested on Full diff: https://github.com/llvm/llvm-project/pull/109111.diff 1 Files Affected:
diff --git a/compiler-rt/test/asan/TestCases/Linux/odr_c_test.c b/compiler-rt/test/asan/TestCases/Linux/odr_c_test.c
index 9929b4a67af38f..4aafe6888c6843 100644
--- a/compiler-rt/test/asan/TestCases/Linux/odr_c_test.c
+++ b/compiler-rt/test/asan/TestCases/Linux/odr_c_test.c
@@ -10,6 +10,9 @@
// RUN: %clang_asan -fcommon %s -fPIC -shared -mllvm -asan-use-private-alias=1 -o %dynamiclib2 -DFILE2
// RUN: %run %t 2>&1 | count 0
+// Unaligned accesses don't work on strict-alignment targets like SPARC.
+// UNSUPPORTED: sparc-target-arch
+
// CHECK: The following global variable is not properly aligned.
// CHECK: ERROR: AddressSanitizer: odr-violation
#if defined(FILE1)
|
vitalybuka
approved these changes
Sep 18, 2024
tmsri
pushed a commit
to tmsri/llvm-project
that referenced
this pull request
Sep 19, 2024
When ASan testing is enabled on SPARC as per PR llvm#107405, the ``` AddressSanitizer-sparc-linux :: TestCases/Linux/odr_c_test.c ``` test `FAIL`s on Linux/sparc64: ``` + projects/compiler-rt/test/asan/SPARCLinuxConfig/TestCases/Linux/Output/odr_c_test.c.tmp + count 0 Expected 0 lines, got 13. AddressSanitizer:DEADLYSIGNAL ================================================================= ==4165420==ERROR: AddressSanitizer: BUS on unknown address (pc 0x7012d5b4 bp 0xffa3b938 sp 0xffa3b8d0 T0) ==4165420==The signal is caused by a READ memory access. ==4165420==Hint: this fault was caused by a dereference of a high value address (see register values below). Disassemble the provided pc to learn which register was used. ``` The test relies on an unaligned access, which cannot work on a strict-alignment target like SPARC. Thus this patch skips the test. Tested on `sparc64-unknown-linux-gnu`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ASan testing is enabled on SPARC as per PR #107405, the
test
FAILs on Linux/sparc64:The test relies on an unaligned access, which cannot work on a strict-alignment target like SPARC.
Thus this patch skips the test.
Tested on
sparc64-unknown-linux-gnu.