-
Notifications
You must be signed in to change notification settings - Fork 14.3k
github: Add tablegen directories to PR autolabeler #109129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: Add tablegen directories to PR autolabeler #109129
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. You'll need to wait for @tstellar to create the pr-subscribers-tablegen
team before merging this though.
tablegen: | ||
- llvm/include/TableGen/** | ||
- llvm/lib/TableGen/** | ||
- llvm/utils/TableGen/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to include llvm/test/TableGen
and llvm/unittests/TableGen
?
I thought the plan was to get rid of the pr-subscribers lists. I removed myself from all of those a while ago |
Maybe eventually if Github lets you do label-based subscriptions for PRs, but I believe they only support that for issues currently. That's still how notifications are done currently as far as I can tell. |
Yeah. Sadly, PRs are for some reason unknown to me are excluded from label-based subscriptions and notifications. |
@llvm/pr-subscribers-tablegen Author: Matt Arsenault (arsenm) ChangesFull diff: https://github.com/llvm/llvm-project/pull/109129.diff 1 Files Affected:
diff --git a/.github/new-prs-labeler.yml b/.github/new-prs-labeler.yml
index 8789495ec2fe9c..8cc6c36fa945b7 100644
--- a/.github/new-prs-labeler.yml
+++ b/.github/new-prs-labeler.yml
@@ -1008,3 +1008,8 @@ bazel:
offload:
- offload/**
+
+tablegen:
+ - llvm/include/TableGen/**
+ - llvm/lib/TableGen/**
+ - llvm/utils/TableGen/**
|
The team is created. |
No description provided.