Skip to content

github: Add tablegen directories to PR autolabeler #109129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Sep 18, 2024

No description provided.

@arsenm arsenm added the github-prs label Sep 18, 2024 — with Graphite App
Copy link
Contributor Author

arsenm commented Sep 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @arsenm and the rest of your teammates on Graphite Graphite

@arsenm arsenm requested review from boomanaiden154, pogo59, tstellar, georgemitenkov and asl and removed request for georgemitenkov September 18, 2024 12:39
@arsenm arsenm marked this pull request as ready for review September 18, 2024 12:41
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You'll need to wait for @tstellar to create the pr-subscribers-tablegen team before merging this though.

tablegen:
- llvm/include/TableGen/**
- llvm/lib/TableGen/**
- llvm/utils/TableGen/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to include llvm/test/TableGen and llvm/unittests/TableGen?

@arsenm
Copy link
Contributor Author

arsenm commented Sep 18, 2024

LGTM. You'll need to wait for @tstellar to create the pr-subscribers-tablegen team before merging this though.

I thought the plan was to get rid of the pr-subscribers lists. I removed myself from all of those a while ago

@boomanaiden154
Copy link
Contributor

I thought the plan was to get rid of the pr-subscribers lists. I removed myself from all of those a while ago

Maybe eventually if Github lets you do label-based subscriptions for PRs, but I believe they only support that for issues currently. That's still how notifications are done currently as far as I can tell.

@asl
Copy link
Collaborator

asl commented Sep 18, 2024

Maybe eventually if Github lets you do label-based subscriptions for PRs, but I believe they only support that for issues currently. That's still how notifications are done currently as far as I can tell.

Yeah. Sadly, PRs are for some reason unknown to me are excluded from label-based subscriptions and notifications.

@llvmbot
Copy link
Member

llvmbot commented Sep 19, 2024

@llvm/pr-subscribers-tablegen

Author: Matt Arsenault (arsenm)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/109129.diff

1 Files Affected:

  • (modified) .github/new-prs-labeler.yml (+5)
diff --git a/.github/new-prs-labeler.yml b/.github/new-prs-labeler.yml
index 8789495ec2fe9c..8cc6c36fa945b7 100644
--- a/.github/new-prs-labeler.yml
+++ b/.github/new-prs-labeler.yml
@@ -1008,3 +1008,8 @@ bazel:
 
 offload:
   - offload/**
+
+tablegen:
+  - llvm/include/TableGen/**
+  - llvm/lib/TableGen/**
+  - llvm/utils/TableGen/**

@tstellar
Copy link
Collaborator

The team is created.

@arsenm arsenm merged commit 1bc59e5 into main Sep 20, 2024
12 checks passed
@arsenm arsenm deleted the users/arsenm/github-pr-labeler-tablegen-directories branch September 20, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants