[bazel] Remove empty Rename tests for now-deleted clang-rename #109162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed in llvm#108988, the tool is fine but the glob for tests is now empty because all the tests were deleted.
d0k
approved these changes
Sep 18, 2024
|
Arguably we should actually restore the Rename tests since they exercise functionality used elsewhere, even if |
Yes, exactly -- this change should be reverted later if that happens. |
tmsri
pushed a commit
to tmsri/llvm-project
that referenced
this pull request
Sep 19, 2024
…109162) Removed in llvm#108988, the tool is fine but the glob for tests is now empty because all the tests were deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed in #108988, the tool is fine but the glob for tests is now empty because all the tests were deleted.