Skip to content

[NFC] Cleanup RegisterInfoEmitter code #109199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

jurahul
Copy link
Contributor

@jurahul jurahul commented Sep 18, 2024

Change variable name o to OS to match definition, and
ClName to ClassName for better clarity.

Cache RegBank reference in the class and do no pass around
class members to functions.

Change variable name `o` to `OS` to match definition, and `ClName`
to `ClassName` for better clarity.

Cache RegBank reference in the class and do no pass around class
members to functions.
@jurahul jurahul marked this pull request as ready for review September 19, 2024 01:45
Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jurahul jurahul merged commit 0f06f70 into llvm:main Sep 19, 2024
11 checks passed
@jurahul jurahul deleted the nfc_reginfo_emitter_cleanup branch September 19, 2024 04:42
tmsri pushed a commit to tmsri/llvm-project that referenced this pull request Sep 19, 2024
Change variable name `o` to `OS` to match definition, and 
`ClName` to `ClassName` for better clarity.

Cache RegBank reference in the class and do no pass around
class members to functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants