[MachineVerifier] Improve G_EXTRACT_SUBVECTOR checking #109202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s smaller than the source.
llvm/lib/CodeGen/MachineVerifier.cpp
Outdated
| @@ -1793,8 +1799,7 @@ void MachineVerifier::verifyPreISelGenericInstruction(const MachineInstr *MI) { | |||
| } | |||
|
|
|||
| uint64_t SrcMinLen = SrcTy.getElementCount().getKnownMinValue(); | |||
| if (SrcTy.isScalable() == DstTy.isScalable() && | |||
| (Idx >= SrcMinLen || Idx + DstMinLen > SrcMinLen)) { | |||
| if ((Idx >= SrcMinLen || Idx + DstMinLen > SrcMinLen)) { | |||
There was a problem hiding this comment.
I think you can drop () pair
topperc
changed the title
tmsri
pushed a commit
to tmsri/llvm-project
that referenced
this pull request
Sep 19, 2024
Check that the destination of G_EXTRACT_SUBVECTOR is smaller than the source. Improve wording of error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that the destination of G_EXTRACT_SUBVECTOR is smaller than the source.
Fix wording of error messages