[MachineVerifier] Improve checks for G_INSERT_SUBVECTOR. #109209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup messages. Remove redundant checks that are handled in geneirc code. Add overrun check. Add checks that subvector is smaller than the vector.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
| @@ -11,9 +11,11 @@ body: | | |||
| %1:_(<vscale x 2 x s32>) = G_IMPLICIT_DEF | |||
| %2:_(<vscale x 1 x s32>) = G_IMPLICIT_DEF | |||
|
|
|||
| ; CHECK: generic instruction must use register operands | |||
There was a problem hiding this comment.
Is this supposed to say generic instruction must use register operands? looks unrelated
There was a problem hiding this comment.
anything that has a type declared in the .td automatically generates a check that the operand is a register. This handles a significant portion of the generic instructions like G_ADD, G_FADD without writing any custom code.
I was going to remove the error from G_INSERT_SUBVECTOR and G_EXTRACT_SUBVECTOR, but we need the call to isReg() to avoid an assert in getReg() later. The assert will crash the test without letting us get through all the test cases.
tmsri
pushed a commit
to tmsri/llvm-project
that referenced
this pull request
Sep 19, 2024
-Improve messages. -Remove redundant checks that are handled in generic code. -Add check that the subvector is smaller than the vector. -Add checks that subvector is smaller than the vector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup messages.
Remove redundant checks that are handled in generic code.
Add overrun check.
Add checks that subvector is smaller than the vector.