[SandboxIR] Add Instruction::isStackSaveRestoreIntrinsic() and isMemDepCandidate() #109212

vporpo · 2024-09-18T22:38:48Z

These are helper functions to be used by the vectorizer's dependency graph.

aeubanks · 2024-09-18T23:16:25Z

llvm/include/llvm/SandboxIR/SandboxIR.h

@@ -1943,6 +1945,26 @@ class Instruction : public sandboxir::User {
  /// LangRef.html for the meaning of these flags.
  void copyFastMathFlags(FastMathFlags FMF);

+  bool isStackSaveRestoreIntrinsic() const {


Suggested change

bool isStackSaveRestoreIntrinsic() const {

bool isStackSaveOrRestoreIntrinsic() const {

…mDepCandidate() These are helper functions to be used by the vectorizer's dependency graph.

llvm-ci · 2024-09-19T00:48:36Z

LLVM Buildbot has detected a new failure on builder ppc64le-lld-multistage-test running on ppc64le-lld-multistage-test while building llvm at step 12 "build-stage2-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/168/builds/3482

Here is the relevant piece of the build log for the reference

Step 12 (build-stage2-unified-tree) failure: build (failure)
...
16.921 [1/8/15] Building CXX object tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/TableGen.cpp.o
32.620 [1/7/16] Building CXX object tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/ClangOpenCLBuiltinEmitter.cpp.o
38.596 [1/6/17] Building CXX object tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/SveEmitter.cpp.o
43.320 [1/5/18] Building CXX object tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/ClangDiagnosticsEmitter.cpp.o
61.527 [1/4/19] Building CXX object tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/RISCVVEmitter.cpp.o
64.041 [1/3/20] Building CXX object tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/MveEmitter.cpp.o
71.994 [1/2/21] Building CXX object tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/NeonEmitter.cpp.o
119.731 [1/1/22] Building CXX object tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/ClangAttrEmitter.cpp.o
120.697 [0/1/23] Linking CXX executable bin/clang-tblgen
239.279 [3833/144/2281] Building CXX object unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/SandboxIRTest.cpp.o
FAILED: unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/SandboxIRTest.cpp.o 
ccache /home/buildbots/llvm-external-buildbots/workers/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/install/stage1/bin/clang++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/build/stage2/unittests/SandboxIR -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/llvm-project/llvm/unittests/SandboxIR -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/build/stage2/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/llvm-project/llvm/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/llvm-project/third-party/unittest/googletest/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/llvm-project/third-party/unittest/googlemock/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -MD -MT unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/SandboxIRTest.cpp.o -MF unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/SandboxIRTest.cpp.o.d -o unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/SandboxIRTest.cpp.o -c /home/buildbots/llvm-external-buildbots/workers/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/llvm-project/llvm/unittests/SandboxIR/SandboxIRTest.cpp
/home/buildbots/llvm-external-buildbots/workers/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/llvm-project/llvm/unittests/SandboxIR/SandboxIRTest.cpp:1754:9: error: unused variable 'Arg' [-Werror,-Wunused-variable]
 1754 |   auto *Arg = F->getArg(0);
      |         ^~~
1 error generated.
267.424 [3833/36/2389] Building CXX object lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/SelectionDAG.cpp.o
267.620 [3833/34/2391] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/SimplifyCFG.cpp.o
268.072 [3833/33/2392] Building CXX object lib/Bitcode/Reader/CMakeFiles/LLVMBitReader.dir/BitcodeReader.cpp.o
268.927 [3833/32/2393] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/VirtualFileSystemTest.cpp.o
269.973 [3833/31/2394] Building CXX object lib/Object/CMakeFiles/LLVMObject.dir/ELF.cpp.o
270.670 [3833/30/2395] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/Attributor.cpp.o
271.529 [3833/29/2396] Building CXX object lib/Object/CMakeFiles/LLVMObject.dir/ELFObjectFile.cpp.o
271.625 [3833/28/2397] Building CXX object utils/TableGen/CMakeFiles/llvm-tblgen.dir/AsmMatcherEmitter.cpp.o
271.907 [3833/27/2398] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LiveDebugValues/InstrRefBasedImpl.cpp.o
274.543 [3833/26/2399] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/MathExtrasTest.cpp.o
274.876 [3833/25/2400] Building CXX object lib/AsmParser/CMakeFiles/LLVMAsmParser.dir/LLParser.cpp.o
275.562 [3833/24/2401] Building CXX object lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/ELF/ELFObject.cpp.o
277.618 [3833/23/2402] Building CXX object tools/llvm-profdata/CMakeFiles/llvm-profdata.dir/llvm-profdata.cpp.o
278.696 [3833/22/2403] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/DenseMapTest.cpp.o
280.837 [3833/21/2404] Building CXX object lib/Frontend/OpenMP/CMakeFiles/LLVMFrontendOpenMP.dir/OMPIRBuilder.cpp.o
281.342 [3833/20/2405] Building CXX object lib/Passes/CMakeFiles/LLVMPasses.dir/PassBuilderPipelines.cpp.o
281.388 [3833/19/2406] Building CXX object unittests/ProfileData/CMakeFiles/ProfileDataTests.dir/InstrProfTest.cpp.o
283.728 [3833/18/2407] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/ScalarEvolution.cpp.o
284.212 [3833/17/2408] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/MemProfContextDisambiguation.cpp.o
284.495 [3833/16/2409] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/APFloatTest.cpp.o
285.775 [3833/15/2410] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/CodeGenPrepare.cpp.o
286.830 [3833/14/2411] Building CXX object lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/SelectionDAGBuilder.cpp.o
289.275 [3833/13/2412] Building CXX object unittests/IR/CMakeFiles/IRTests.dir/MetadataTest.cpp.o
297.002 [3833/12/2413] Building CXX object lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/LoopVectorize.cpp.o
300.795 [3833/11/2414] Building CXX object unittests/Frontend/CMakeFiles/LLVMFrontendTests.dir/OpenMPIRBuilderTest.cpp.o
308.431 [3833/10/2415] Building CXX object unittests/Transforms/Scalar/CMakeFiles/ScalarTests.dir/LoopPassManagerTest.cpp.o
311.072 [3833/9/2416] Building CXX object unittests/Frontend/CMakeFiles/LLVMFrontendTests.dir/OpenMPDecompositionTest.cpp.o
312.588 [3833/8/2417] Building CXX object lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/DAGCombiner.cpp.o
313.827 [3833/7/2418] Building CXX object tools/obj2yaml/CMakeFiles/obj2yaml.dir/elf2yaml.cpp.o
317.391 [3833/6/2419] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/AttributorAttributes.cpp.o
322.181 [3833/5/2420] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/OpenMPOpt.cpp.o
323.444 [3833/4/2421] Building CXX object unittests/IR/CMakeFiles/IRTests.dir/PassBuilderCallbacksTest.cpp.o
408.844 [3833/3/2422] Building CXX object lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/SLPVectorizer.cpp.o

vporpo · 2024-09-19T00:59:46Z

9f5139c should fix the build issue.

…epCandidate() (llvm#109212) These are helper functions to be used by the vectorizer's dependency graph.

vporpo requested review from slackito, aeubanks and Sterling-Augustine September 18, 2024 22:38

aeubanks reviewed Sep 18, 2024

View reviewed changes

aeubanks approved these changes Sep 18, 2024

View reviewed changes

[SandboxIR] Add Instruction::isStackSaveOrRestoreIntrinsic() and isMe…

013c059

…mDepCandidate() These are helper functions to be used by the vectorizer's dependency graph.

vporpo force-pushed the DAG branch from dbb3106 to 013c059 Compare September 18, 2024 23:21

vporpo merged commit 1bda7ba into llvm:main Sep 19, 2024
6 of 7 checks passed

tmsri pushed a commit to tmsri/llvm-project that referenced this pull request Sep 19, 2024

[SandboxIR] Add Instruction::isStackSaveRestoreIntrinsic() and isMemD…

e758e7c

…epCandidate() (llvm#109212) These are helper functions to be used by the vectorizer's dependency graph.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SandboxIR] Add Instruction::isStackSaveRestoreIntrinsic() and isMemDepCandidate() #109212

[SandboxIR] Add Instruction::isStackSaveRestoreIntrinsic() and isMemDepCandidate() #109212

Uh oh!

vporpo commented Sep 18, 2024

Uh oh!

aeubanks Sep 18, 2024

Uh oh!

vporpo Sep 18, 2024

Uh oh!

Uh oh!

llvm-ci commented Sep 19, 2024

Uh oh!

vporpo commented Sep 19, 2024

Uh oh!

Uh oh!

	bool isStackSaveRestoreIntrinsic() const {
	bool isStackSaveOrRestoreIntrinsic() const {

[SandboxIR] Add Instruction::isStackSaveRestoreIntrinsic() and isMemDepCandidate() #109212

[SandboxIR] Add Instruction::isStackSaveRestoreIntrinsic() and isMemDepCandidate() #109212

Uh oh!

Conversation

vporpo commented Sep 18, 2024

Uh oh!

aeubanks Sep 18, 2024

Choose a reason for hiding this comment

Uh oh!

vporpo Sep 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

llvm-ci commented Sep 19, 2024

Uh oh!

vporpo commented Sep 19, 2024

Uh oh!

Uh oh!