[LLVM][TableGen] Speed up sorting of intrinsics #109230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
jurahul
force-pushed
the
intrinsic_emitter_sort_tweak
branch
from
88979af to
41e95d2
Compare
Speed up sorting of intrinsics by using the TargetPrefix to only discriminate beteween target dependent vs target independent intrinsics where target independent ones need to be sorted before target dependent ones. When comaring two target dependent intrinsics, the Name already includes llvm.<TargetPrefix> as a suffix, so no need to needlessly compare it separately.
jurahul
force-pushed
the
intrinsic_emitter_sort_tweak
branch
from
41e95d2 to
fb3928d
Compare
arsenm
approved these changes
Sep 19, 2024
tmsri
pushed a commit
to tmsri/llvm-project
that referenced
this pull request
Sep 19, 2024
Speed up sorting of intrinsics by using the TargetPrefix to only discriminate beteween target dependent vs target independent intrinsics where target independent ones need to be sorted before target dependent ones. When comparing two target dependent intrinsics, the Name already includes `llvm.<TargetPrefix>` as a prefix, so no need to needlessly compare it separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up sorting of intrinsics by using the TargetPrefix to only discriminate beteween target dependent vs target independent intrinsics where target independent ones need to be sorted before target dependent ones. When comparing two target dependent intrinsics, the Name already includes
llvm.<TargetPrefix>as a prefix, so no need to needlessly compare it separately.