Skip to content

[LLVM][TableGen] Change RegisterInfoEmitter to use const RecordKeeper #109237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 13 additions & 16 deletions llvm/utils/TableGen/RegisterInfoEmitter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,12 @@ static cl::opt<bool>
namespace {

class RegisterInfoEmitter {
RecordKeeper &Records;
const RecordKeeper &Records;
const CodeGenTarget Target;
CodeGenRegBank &RegBank;

public:
RegisterInfoEmitter(RecordKeeper &R)
RegisterInfoEmitter(const RecordKeeper &R)
: Records(R), Target(R), RegBank(Target.getRegBank()) {
RegBank.computeDerivedInfo();
}
Expand Down Expand Up @@ -445,7 +445,7 @@ void RegisterInfoEmitter::EmitRegMappingTables(
continue;

DefInit *DI = cast<DefInit>(V->getValue());
Record *Alias = DI->getDef();
const Record *Alias = DI->getDef();
const auto &AliasIter = llvm::lower_bound(
DwarfRegNums, Alias, [](const DwarfRegNumsMapPair &A, const Record *B) {
return LessRecordRegister()(A.first, B);
Expand Down Expand Up @@ -1659,40 +1659,37 @@ void RegisterInfoEmitter::runTargetDesc(raw_ostream &OS) {
OS << "}\n\n";

// Emit CalleeSavedRegs information.
std::vector<Record *> CSRSets =
ArrayRef<const Record *> CSRSets =
Records.getAllDerivedDefinitions("CalleeSavedRegs");
for (unsigned i = 0, e = CSRSets.size(); i != e; ++i) {
Record *CSRSet = CSRSets[i];
for (const Record *CSRSet : CSRSets) {
const SetTheory::RecVec *Regs = RegBank.getSets().expand(CSRSet);
assert(Regs && "Cannot expand CalleeSavedRegs instance");

// Emit the *_SaveList list of callee-saved registers.
OS << "static const MCPhysReg " << CSRSet->getName() << "_SaveList[] = { ";
for (unsigned r = 0, re = Regs->size(); r != re; ++r)
OS << getQualifiedName((*Regs)[r]) << ", ";
for (const Record *Reg : *Regs)
OS << getQualifiedName(Reg) << ", ";
OS << "0 };\n";

// Emit the *_RegMask bit mask of call-preserved registers.
BitVector Covered = RegBank.computeCoveredRegisters(*Regs);

// Check for an optional OtherPreserved set.
// Add those registers to RegMask, but not to SaveList.
if (DagInit *OPDag =
if (const DagInit *OPDag =
dyn_cast<DagInit>(CSRSet->getValueInit("OtherPreserved"))) {
SetTheory::RecSet OPSet;
RegBank.getSets().evaluate(OPDag, OPSet, CSRSet->getLoc());
Covered |= RegBank.computeCoveredRegisters(
ArrayRef<const Record *>(OPSet.begin(), OPSet.end()));
Covered |= RegBank.computeCoveredRegisters(OPSet.getArrayRef());
}

// Add all constant physical registers to the preserved mask:
SetTheory::RecSet ConstantSet;
for (auto &Reg : RegBank.getRegisters()) {
for (const auto &Reg : RegBank.getRegisters()) {
if (Reg.Constant)
ConstantSet.insert(Reg.TheDef);
}
Covered |= RegBank.computeCoveredRegisters(
ArrayRef<const Record *>(ConstantSet.begin(), ConstantSet.end()));
Covered |= RegBank.computeCoveredRegisters(ConstantSet.getArrayRef());

OS << "static const uint32_t " << CSRSet->getName() << "_RegMask[] = { ";
printBitVectorAsHex(OS, Covered, 32);
Expand All @@ -1704,7 +1701,7 @@ void RegisterInfoEmitter::runTargetDesc(raw_ostream &OS) {
<< "::getRegMasks() const {\n";
if (!CSRSets.empty()) {
OS << " static const uint32_t *const Masks[] = {\n";
for (Record *CSRSet : CSRSets)
for (const Record *CSRSet : CSRSets)
OS << " " << CSRSet->getName() << "_RegMask,\n";
OS << " };\n";
OS << " return ArrayRef(Masks);\n";
Expand Down Expand Up @@ -1784,7 +1781,7 @@ void RegisterInfoEmitter::runTargetDesc(raw_ostream &OS) {
<< "::getRegMaskNames() const {\n";
if (!CSRSets.empty()) {
OS << " static const char *Names[] = {\n";
for (Record *CSRSet : CSRSets)
for (const Record *CSRSet : CSRSets)
OS << " " << '"' << CSRSet->getName() << '"' << ",\n";
OS << " };\n";
OS << " return ArrayRef(Names);\n";
Expand Down
Loading