[mlir][vector][nfc] Update vector load/store doc wrt unit strides. #109267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to llvm#108998. Non-contigious strides are allowed for 1-slement vector load/stores.
Hardcode84
requested review from
MaheshRavishankar,
banach-space,
nicolasvasilache and
dcaballe
|
@llvm/pr-subscribers-mlir-vector @llvm/pr-subscribers-mlir Author: Ivan Butygin (Hardcode84) ChangesFollow up to #108998. Non-contiguous strides are allowed now for 1-element vector load/stores. Full diff: https://github.com/llvm/llvm-project/pull/109267.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td b/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
index b96f5c2651bce5..65ed9b9d3df927 100644
--- a/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
+++ b/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
@@ -1655,6 +1655,7 @@ def Vector_LoadOp : Vector_Op<"load"> {
strides. Only unit strides are allowed along the most minor memref
dimension. These constraints guarantee that elements read along the first
dimension of the slice are contiguous in memory.
+ Non-unit strides are allowed when doing 0-rank or 1-element vector load.
The memref element type can be a scalar or a vector type. If the memref
element type is a scalar, it should match the element type of the result
@@ -1739,6 +1740,7 @@ def Vector_StoreOp : Vector_Op<"store"> {
strided by the memref strides. Only unit strides are allowed along the most
minor memref dimension. These constraints guarantee that elements written
along the first dimension of the slice are contiguous in memory.
+ Non-unit strides are allowed when doing 0-rank or 1-element vector store.
The memref element type can be a scalar or a vector type. If the memref
element type is a scalar, it should match the element type of the value
|
Hardcode84
changed the title
Comment on lines
1655
to
1658
| strides. Only unit strides are allowed along the most minor memref | ||
| dimension. These constraints guarantee that elements read along the first | ||
| dimension of the slice are contiguous in memory. | ||
| Non-unit strides are allowed when doing 0-rank or 1-element vector load. |
There was a problem hiding this comment.
[nit]
Suggested change
| strides. Only unit strides are allowed along the most minor memref | |
| dimension. These constraints guarantee that elements read along the first | |
| dimension of the slice are contiguous in memory. | |
| Non-unit strides are allowed when doing 0-rank or 1-element vector load. | |
| strides. When loading more than 1 element, only unit strides are allowed along the most minor memref | |
| dimension. These constraints guarantee that elements read along the first | |
| dimension of the slice are contiguous in memory. |
Rather than adding a sentence at the end (and splitting one condition across multiple sentences), why not just refine the current wording? Hope I'm not splitting hairs here 😅
There was a problem hiding this comment.
yeah, that's better, probably.
tmsri
pushed a commit
to tmsri/llvm-project
that referenced
this pull request
Sep 19, 2024
…lvm#109267) Follow up to llvm#108998. Non-contiguous strides are allowed now for 1-element vector load/stores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #108998.
Non-contiguous strides are allowed now for 1-element vector load/stores.