Skip to content

[flang][cuf][NFC] Clean up unused header and library #109326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

clementval
Copy link
Contributor

These were part of a previous attempt and are not needed anymore.

@clementval clementval requested a review from vzakhari September 19, 2024 19:54
@llvmbot llvmbot added flang:runtime flang Flang issues not falling into any other category labels Sep 19, 2024
@llvmbot
Copy link
Member

llvmbot commented Sep 19, 2024

@llvm/pr-subscribers-flang-runtime

Author: Valentin Clement (バレンタイン クレメン) (clementval)

Changes

These were part of a previous attempt and are not needed anymore.


Full diff: https://github.com/llvm/llvm-project/pull/109326.diff

2 Files Affected:

  • (modified) flang/runtime/CUDA/CMakeLists.txt (-3)
  • (modified) flang/runtime/CUDA/allocatable.cpp (-1)
diff --git a/flang/runtime/CUDA/CMakeLists.txt b/flang/runtime/CUDA/CMakeLists.txt
index 803ff01b945dc4..193dd77e934558 100644
--- a/flang/runtime/CUDA/CMakeLists.txt
+++ b/flang/runtime/CUDA/CMakeLists.txt
@@ -18,9 +18,6 @@ add_flang_library(${CUFRT_LIBNAME}
   allocatable.cpp
   descriptor.cpp
   memory.cpp
-
-  LINK_COMPONENTS
-  Support
 )
 
 if (BUILD_SHARED_LIBS)
diff --git a/flang/runtime/CUDA/allocatable.cpp b/flang/runtime/CUDA/allocatable.cpp
index cc0c647c6c9529..649ddb638abe6d 100644
--- a/flang/runtime/CUDA/allocatable.cpp
+++ b/flang/runtime/CUDA/allocatable.cpp
@@ -12,7 +12,6 @@
 #include "flang/Runtime/CUDA/common.h"
 #include "flang/Runtime/CUDA/descriptor.h"
 #include "flang/Runtime/allocatable.h"
-#include "llvm/Support/ErrorHandling.h"
 
 #include "cuda_runtime.h"
 

@clementval clementval merged commit 434c9c5 into llvm:main Sep 19, 2024
8 of 10 checks passed
@clementval clementval deleted the cuf_cleanup_support branch September 19, 2024 19:56
tmsri pushed a commit to tmsri/llvm-project that referenced this pull request Sep 19, 2024
These were part of a previous attempt and are not needed anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:runtime flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants