[Clang] - Add libclangSerialization to clang driver unittests

[bhandarkar-pranav]

This PR is a fix for issue #109328. libclangSerializaton.so is needed for building clang driver unittests after
#76838 was merged. Needed for builds with BUILD_SHARED_LIBS=ON

[llvmbot]

@llvm/pr-subscribers-clang

@llvm/pr-subscribers-clang-driver

Author: Pranav Bhandarkar (bhandarkar-pranav)

Changes

This PR is a fix for issue #109328. libclangSerializaton.so is needed for building clang driver unittests after
#76838 was merged.

---

Full diff: https://github.com/llvm/llvm-project/pull/109329.diff

1 Files Affected:

• (modified) clang/unittests/Driver/CMakeLists.txt (+1)

diff --git a/clang/unittests/Driver/CMakeLists.txt b/clang/unittests/Driver/CMakeLists.txt
index 752037f78fb147..efdd07ea238890 100644
--- a/clang/unittests/Driver/CMakeLists.txt
+++ b/clang/unittests/Driver/CMakeLists.txt
@@ -22,4 +22,5 @@ clang_target_link_libraries(ClangDriverTests
   clangDriver
   clangBasic
   clangFrontend # For TextDiagnosticPrinter.
+  clangSerialization
   )

[Prabhuk]

Thank you Pranav! This looks like a reasonable fix to me. I just created a revert PR though since I cannot test this right away locally.

[Prabhuk]

I am holding off of on my revert PR to see if the current build bot with this patch goes through successfully! Thanks again Pranav.

[Prabhuk]

It seems like we are still seeing failures: https://lab.llvm.org/buildbot/#/builders/190/builds/6112

[Prabhuk]

I just merged my revert PR #109340
I'll investigate further on the cause for the warning that shows up in the build bots causing the test failure

[bhandarkar-pranav]

I just merged my revert PR #109340 I'll investigate further on the cause for the warning that shows up in the build bots causing the test failure

Sounds good. As you can see, my fix is unrelated to this issue that you are seeing which seems to be real issue worth investigating.