[AA] Take account of C++23's stricter rules for forward declarations (NFC) #109416
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
llvmbot
added
the
llvm:analysis
|
@llvm/pr-subscribers-llvm-analysis Author: Jonathan Tanner (aDifferentJT) ChangesFull diff: https://github.com/llvm/llvm-project/pull/109416.diff 2 Files Affected:
diff --git a/llvm/include/llvm/Analysis/AliasAnalysis.h b/llvm/include/llvm/Analysis/AliasAnalysis.h
index 1990172116582b..9c6084d2d9deeb 100644
--- a/llvm/include/llvm/Analysis/AliasAnalysis.h
+++ b/llvm/include/llvm/Analysis/AliasAnalysis.h
@@ -315,7 +315,7 @@ class AAResults {
public:
// Make these results default constructable and movable. We have to spell
// these out because MSVC won't synthesize them.
- AAResults(const TargetLibraryInfo &TLI) : TLI(TLI) {}
+ AAResults(const TargetLibraryInfo &TLI);
AAResults(AAResults &&Arg);
~AAResults();
diff --git a/llvm/lib/Analysis/AliasAnalysis.cpp b/llvm/lib/Analysis/AliasAnalysis.cpp
index 9f529fde55c20f..d90bb213f4208b 100644
--- a/llvm/lib/Analysis/AliasAnalysis.cpp
+++ b/llvm/lib/Analysis/AliasAnalysis.cpp
@@ -73,6 +73,8 @@ static cl::opt<bool> EnableAATrace("aa-trace", cl::Hidden, cl::init(false));
static const bool EnableAATrace = false;
#endif
+AAResults::AAResults(const TargetLibraryInfo &TLI) : TLI(TLI) {}
+
AAResults::AAResults(AAResults &&Arg)
: TLI(Arg.TLI), AAs(std::move(Arg.AAs)), AADeps(std::move(Arg.AADeps)) {}
|
There was a problem hiding this comment.
Thank you for the fix.
I have not look at the issue in detail but your summary needs to be filled out. It should include a high level description of the problem the PR is solving and the approach being used to fix it.
As well you should include a link to the bug being fixed with some thing like "Fixes: <link to bug report".
The title of the PR should also describe the problem being fixed.
This also need a release note.
aDifferentJT
changed the title
nikic
changed the title
|
Also, I don't know the exact procedure (forgive me, this is my first LLVM PR), but it seems from the docs as if some PRs/issues get highlighted for backporting. This is the one issue blocking C++23 adoption in my project, and showed up as soon as I included some high level LLVM headers, I doubt I'm the only one in that boat so it would seem like a good candidate to me. Thanks for bearing with my inexperience. |
|
@aDifferentJT Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
|
/cherry-pick 76bc1ed |
…(NFC) (llvm#109416) C++23 has stricter rules for forward declarations around std::unique_ptr, this means that the inline declaration of the constructor was failing under clang in C++23 mode, switching to an out-of-line definition of the constructor fixes this. This was fairly major impact as it blocked inclusion of a lot of headers under clang in C++23 mode. Fixes llvm#106597. (cherry picked from commit 76bc1ed)
|
/pull-request #109476 |
…(NFC) (llvm#109416) C++23 has stricter rules for forward declarations around std::unique_ptr, this means that the inline declaration of the constructor was failing under clang in C++23 mode, switching to an out-of-line definition of the constructor fixes this. This was fairly major impact as it blocked inclusion of a lot of headers under clang in C++23 mode. Fixes llvm#106597. (cherry picked from commit 76bc1ed)
C++23 has stricter rules for forward declarations around std::unique_ptr, this means that the inline declaration of the constructor was failing under clang in C++23 mode, switching to an out-of-line definition of the constructor fixes this.
This was fairly major impact as it blocked inclusion of a lot of headers under clang in C++23 mode.
Fixes #106597.