Skip to content

[mlir][memref] Add builder that infers reinterpret_cast result type #109432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024
Merged

[mlir][memref] Add builder that infers reinterpret_cast result type #109432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1407,6 +1407,10 @@ def MemRef_ReinterpretCastOp
"OpFoldResult":$offset, "ArrayRef<OpFoldResult>":$sizes,
"ArrayRef<OpFoldResult>":$strides,
CArg<"ArrayRef<NamedAttribute>", "{}">:$attrs)>,
// Build a ReinterpretCastOp and infer the result type.
OpBuilder<(ins "Value":$source, "OpFoldResult":$offset,
"ArrayRef<OpFoldResult>":$sizes, "ArrayRef<OpFoldResult>":$strides,
CArg<"ArrayRef<NamedAttribute>", "{}">:$attrs)>,
// Build a ReinterpretCastOp with static entries.
OpBuilder<(ins "MemRefType":$resultType, "Value":$source,
"int64_t":$offset, "ArrayRef<int64_t>":$sizes,
Expand Down
6 changes: 4 additions & 2 deletions mlir/lib/Dialect/Bufferization/IR/BufferDeallocationOpInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,10 @@ LogicalResult DeallocationState::getMemrefsAndConditionsToDeallocate(
// that we can call extract_strided_metadata on it.
if (auto unrankedMemRefTy = dyn_cast<UnrankedMemRefType>(memref.getType()))
memref = builder.create<memref::ReinterpretCastOp>(
loc, MemRefType::get({}, unrankedMemRefTy.getElementType()), memref,
0, SmallVector<int64_t>{}, SmallVector<int64_t>{});
loc, memref,
/*offset=*/builder.getIndexAttr(0),
/*sizes=*/ArrayRef<OpFoldResult>{},
/*strides=*/ArrayRef<OpFoldResult>{});

// Use the `memref.extract_strided_metadata` operation to get the base
// memref. This is needed because the same MemRef that was produced by the
Expand Down
18 changes: 18 additions & 0 deletions mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1832,6 +1832,24 @@ void ReinterpretCastOp::build(OpBuilder &b, OperationState &result,
b.getDenseI64ArrayAttr(staticStrides));
}

void ReinterpretCastOp::build(OpBuilder &b, OperationState &result,
Value source, OpFoldResult offset,
ArrayRef<OpFoldResult> sizes,
ArrayRef<OpFoldResult> strides,
ArrayRef<NamedAttribute> attrs) {
auto sourceType = cast<BaseMemRefType>(source.getType());
SmallVector<int64_t> staticOffsets, staticSizes, staticStrides;
SmallVector<Value> dynamicOffsets, dynamicSizes, dynamicStrides;
dispatchIndexOpFoldResults(offset, dynamicOffsets, staticOffsets);
dispatchIndexOpFoldResults(sizes, dynamicSizes, staticSizes);
dispatchIndexOpFoldResults(strides, dynamicStrides, staticStrides);
auto stridedLayout = StridedLayoutAttr::get(
b.getContext(), staticOffsets.front(), staticStrides);
auto resultType = MemRefType::get(staticSizes, sourceType.getElementType(),
stridedLayout, sourceType.getMemorySpace());
build(b, result, resultType, source, offset, sizes, strides, attrs);
}

void ReinterpretCastOp::build(OpBuilder &b, OperationState &result,
MemRefType resultType, Value source,
int64_t offset, ArrayRef<int64_t> sizes,
Expand Down
Loading