[MIPS] Fix failing to legalize load+call with vector of non-p2 intege… #109625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Sep 23, 2024
| @@ -124,7 +124,8 @@ unsigned MipsTargetLowering::getNumRegistersForCallingConv(LLVMContext &Context, | |||
| unsigned MipsTargetLowering::getVectorTypeBreakdownForCallingConv( | |||
| LLVMContext &Context, CallingConv::ID CC, EVT VT, EVT &IntermediateVT, | |||
| unsigned &NumIntermediates, MVT &RegisterVT) const { | |||
| if (VT.isPow2VectorType()) { | |||
|
|
|||
| @@ -0,0 +1,30 @@ | |||
| ; RUN: llc -mtriple=mips-linux-gnu -mcpu=mips32 < %s | FileCheck %s --check-prefix=MIPS32 | |||
|
|
|||
| define void @call_v1i80() { | |||
There was a problem hiding this comment.
Add nounwind to suppress cfi.
| ; MIPS32-NEXT: jr $ra | ||
| ; MIPS32-NEXT: addiu $sp, $sp, 8 | ||
| Entry: | ||
| %0 = load <1 x i80>, ptr null, align 16 |
There was a problem hiding this comment.
This test case is over-reduced. Does the problem still reproduce if you replace the nulls here with a real pointer and a real function declaration?
There was a problem hiding this comment.
Yes, this situation you mentioned also can be solved and the reported bug info was same as null pointer situation. I tested the following test case.
$ cat 1.ll
target datalayout = "e-m:m-p:32:32-i8:8:32-i16:16:32-i64:64-n32-S64"
target triple = "mipsel-unknown-linux-unknown"
define void @arg_v1i80(<1 x i80> %vec, ptr %p) {
store <1 x i80> %vec, ptr %p
ret void
}
define void @_start(ptr %p) nounwind{
Entry:
%0 = load <1 x i80>, ptr %p, align 16
call void @arg_v1i80(<1 x i80> %0)
ret void
}
nikic
reviewed
Sep 23, 2024
There was a problem hiding this comment.
I'd add this to the illegal-vectors.ll test, which has a lot of related coverage.
There was a problem hiding this comment.
Need I added call_v1i80 to this file?
There was a problem hiding this comment.
Move test to illegal-vectors.ll done.
…r type Add a condition to check whether the vector element type is a power of 2. Fix llvm#102870.
yingopq
force-pushed
the
Fix_bug_issue_102870
branch
from
85cb620 to
8c0a0f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r type
Add a condition to check whether the vector element type is a power of 2.
Fix #102870.