[SandboxIR][Utils] Implement getMemoryLocation() #109724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping |
Sterling-Augustine
approved these changes
Sep 25, 2024
| if (BB.getName() == Name) | ||
| return &BB; | ||
| llvm_unreachable("Expected to find basic block!"); | ||
| } |
There was a problem hiding this comment.
We should probably refactor the parseIR/getBasicBlockByName boilerplate into something common for the entire SandboxVectorizer. Every test file duplicates it. But that is a problem for the future.
There was a problem hiding this comment.
Yes, that needs to be refactored at some point.
llvm/include/llvm/SandboxIR/Utils.h
Outdated
|
|
||
| /// Equivalent to MemoryLocation::getOrNone(I). | ||
| static std::optional<llvm::MemoryLocation> | ||
| getMemoryLocation(const Instruction *I) { |
There was a problem hiding this comment.
Why not match the name?
There was a problem hiding this comment.
Something like memoryLocationGetOrNone() ?
There was a problem hiding this comment.
I think that makes it clearer. In my opinion, the closer we match the LLVM IR name, the easier it is to reason about.
This patch implements sandboxir::Utils::getMemoryLocation() that calls MemoryLocation::getOrNone() internally. Ideally this would require a sandboxir::MemoryLocation, but this should be good enough for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements sandboxir::Utils::getMemoryLocation() that calls MemoryLocation::getOrNone() internally.
Ideally this would require a sandboxir::MemoryLocation, but this should be good enough for now.