Skip to content

[libc++] Re-enable Clang-tidy checks in the CI #110026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2024
Merged

[libc++] Re-enable Clang-tidy checks in the CI #110026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85f849d
[libc++] Re-enable Clang-tidy checks in the CI
ldionne Sep 25, 2024
8c0f694
Fix a few clang-tidy issues that crept into the code base while it wa…
ldionne Nov 28, 2024
191a05b
Fix clang-tidy issues the right way
ldionne Nov 29, 2024
6cb289b
Formatting
ldionne Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion libcxx/include/chrono
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,7 +998,6 @@ constexpr chrono::year operator ""y(unsigned lo
# include <cstdint>
# include <stdexcept>
# include <string_view>
# include <vector>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this have to be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It triggers a duplicate include warning with the one in the _LIBCPP_STD_VER <= 20 block below.

#endif

#if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20
Expand Down
3 changes: 2 additions & 1 deletion libcxx/test/libcxx/clang_tidy.gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

import sys
sys.path.append(sys.argv[1])
from libcxx.header_information import lit_header_restrictions, public_headers
from libcxx.header_information import lit_header_restrictions, lit_header_undeprecations, public_headers

for header in public_headers:
print(f"""\
Expand All @@ -30,6 +30,7 @@
// UNSUPPORTED: clang-17

{lit_header_restrictions.get(header, '')}
{lit_header_undeprecations.get(header, '')}

// TODO: run clang-tidy with modules enabled once they are supported
// RUN: %{{clang-tidy}} %s --warnings-as-errors=* -header-filter=.* --checks='-*,libcpp-*' --load=%{{test-tools-dir}}/clang_tidy_checks/libcxx-tidy.plugin -- %{{compile_flags}} -fno-modules
Expand Down
3 changes: 0 additions & 3 deletions libcxx/test/tools/clang_tidy_checks/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
# TODO: Re-enable the tests once the CI is back under control
return()

# The find_package changes these variables. This leaves the build in an odd
# state. Calling cmake a second time tries to write site config information in
# the system's libc++. Restoring these setting after testing fixes this issue.
Expand Down
Loading