[MLIR] Add MLIRConversionPassIncGen to cmake deps for FrozenRewritePatternSet #110054
Conversation
…ritePatternSet Fixes missing header in downstream circt python wheel build (e.g. https://github.com/llvm/circt/actions/runs/11022589675/job/30612234430)
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-mlir Author: Lenny Truong (leonardt) ChangesFixes missing header in downstream circt python wheel build (e.g. https://github.com/llvm/circt/actions/runs/11022589675/job/30612234430). Confirmed by Full diff: https://github.com/llvm/llvm-project/pull/110054.diff 1 Files Affected:
diff --git a/mlir/lib/Rewrite/CMakeLists.txt b/mlir/lib/Rewrite/CMakeLists.txt
index a6c39406aa4b3e..15b3739e4c6337 100644
--- a/mlir/lib/Rewrite/CMakeLists.txt
+++ b/mlir/lib/Rewrite/CMakeLists.txt
@@ -9,6 +9,7 @@ add_mlir_library(MLIRRewrite
DEPENDS
mlir-generic-headers
+ MLIRConversionPassIncGen
LINK_LIBS PUBLIC
MLIRIR
|
There was a problem hiding this comment.
I'm not super familiar with why this library needs this dependency, but I do see it includes this header which transitively includes the generated mlir/Conversion/Passes.h.inc:
So, given the current state, makes sense to me to add the explicit dependency. This seems to have been this way for years... I have no idea why CIRCT Python wheel CI/CD always seems to find these issues.
|
@leonardt Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
…tternSet (llvm#110054) Fixes missing header in downstream circt python wheel build (e.g. https://github.com/llvm/circt/actions/runs/11022589675/job/30612234430). Confirmed by * https://github.com/llvm/circt/actions/runs/11040046220/job/30667073462 * llvm/circt@0646e7e
Fixes missing header in downstream circt python wheel build (e.g. https://github.com/llvm/circt/actions/runs/11022589675/job/30612234430).
Confirmed by