[lineeditor] Add setHistorySize() method for adjusting history size
#110092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@devajithvs, can you rebase this PR? |
devajithvs
force-pushed
the
lineeditor
branch
from
8a0c234 to
1c5281a
Compare
devajithvs
force-pushed
the
lineeditor
branch
from
85ccb70 to
822dbc9
Compare
vgvassilev
approved these changes
Oct 31, 2024
thurstond
added a commit
that referenced
this pull request
Nov 7, 2024
…ory size (#110092)" This reverts commit ec05b88. Reason: buildbot breakage (https://lab.llvm.org/buildbot/#/builders/66/builds/5904) /home/b/sanitizer-x86_64-linux/build/llvm-project/llvm/lib/LineEditor/LineEditor.cpp:23:15: error: unused variable 'DefaultHistorySize' [-Werror,-Wunused-const-variable] 23 | constexpr int DefaultHistorySize = 800; | ^~~~~~~~~~~~~~~~~~ 1 error generated.
Groverkss
pushed a commit
to iree-org/llvm-project
that referenced
this pull request
Nov 15, 2024
…llvm#110092) This patch adds a `setHistorySize` method to `LineEditor`. This is particularly useful for tools like `clang-repl`, `clang-query`, `mlir-query`, and other REPL interfaces, where managing history size might be needed.
Groverkss
pushed a commit
to iree-org/llvm-project
that referenced
this pull request
Nov 15, 2024
…ory size (llvm#110092)" This reverts commit ec05b88. Reason: buildbot breakage (https://lab.llvm.org/buildbot/#/builders/66/builds/5904) /home/b/sanitizer-x86_64-linux/build/llvm-project/llvm/lib/LineEditor/LineEditor.cpp:23:15: error: unused variable 'DefaultHistorySize' [-Werror,-Wunused-const-variable] 23 | constexpr int DefaultHistorySize = 800; | ^~~~~~~~~~~~~~~~~~ 1 error generated.
vgvassilev
pushed a commit
that referenced
this pull request
Dec 2, 2024
…ory size' (#115442) Reland: #110092 Buildbot was failing due to an unused variable warning as there were 2 implementations (with and without libedit). Compared to last version, wrap the variable inside the `#ifdef HAVE_LIBEDIT`. Apologies for the oversight @vgvassilev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a
setHistorySizemethod toLineEditor.This is particularly useful for tools like
clang-repl,clang-query,mlir-query, and other REPL interfaces, where managing history size might be needed.