Skip to content

[libc] Fix 'fgets' test on the GPU for some C libraries #110118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[libc] Fix 'fgets' test on the GPU for some C libraries #110118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libc/test/src/stdio/fgets_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ TEST(LlvmLibcFgetsTest, WriteAndReadCharacters) {
file = LIBC_NAMESPACE::fopen(FILENAME, "r");
ASSERT_FALSE(file == nullptr);

// The GPU build relies on the host C library, so this check may be different.
#ifndef LIBC_TARGET_ARCH_IS_GPU
// If we request just 1 byte, it should return just a null byte and not
// advance the read head. This is implementation defined.
output = LIBC_NAMESPACE::fgets(buff, 1, file);
Expand All @@ -54,6 +56,7 @@ TEST(LlvmLibcFgetsTest, WriteAndReadCharacters) {
// This is also implementation defined.
output = LIBC_NAMESPACE::fgets(buff, 0, file);
ASSERT_TRUE(output == nullptr);
#endif

const char *output_arr[] = {
"1234567", "89\n", "1234567", "\n", "123456\n", "1",
Expand Down
Loading