[AIX][CMake] Disable openmp as LLVM_ENABLE_PROJECTS
#110152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-openmp Author: Daniel Chen (DanielCChen) Changes… Full diff: https://github.com/llvm/llvm-project/pull/110152.diff 1 Files Affected:
diff --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt
index 0044c38f566a78..27f4b0a8796274 100644
--- a/llvm/CMakeLists.txt
+++ b/llvm/CMakeLists.txt
@@ -117,6 +117,13 @@ endif()
# This allows an easy way of setting up a build directory for llvm and another
# one for llvm+clang+... using the same sources.
set(LLVM_ALL_PROJECTS "bolt;clang;clang-tools-extra;compiler-rt;cross-project-tests;libc;libclc;lld;lldb;mlir;openmp;polly;pstl")
+if (${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+ # Disallow 'openmp' as a LLVM PROJECT on AIX as the supported way is to use
+ # LLVM_ENABLE_RUNTIMES.
+ list(REMOVE_ITEM LLVM_ALL_PROJECTS openmp)
+endif()
+
+# The flang project is not yet part of "all" projects (see C++ requirements)
# The flang project is not yet part of "all" projects (see C++ requirements)
set(LLVM_EXTRA_PROJECTS "flang")
# List of all known projects in the mono repo
|
daltenty
reviewed
Sep 26, 2024
| list(REMOVE_ITEM LLVM_ALL_PROJECTS openmp) | ||
| endif() | ||
|
|
||
| # The flang project is not yet part of "all" projects (see C++ requirements) |
There was a problem hiding this comment.
nit: this is a dup. I think this is a duplicate/copy-paste error:
Suggested change
| # The flang project is not yet part of "all" projects (see C++ requirements) |
There was a problem hiding this comment.
Thanks for the review. The dup line is removed.
daltenty
changed the title
openmp as LLVM_ENABLE_PROJECTS in favor of LLVM_ENABLE_RUNTIMES on AIX.openmp as LLVM_ENABLE_PROJECTS
|
What is the reason? Usually |
DanielCChen
force-pushed
the
daniel_omp
branch
from
0b58328 to
d3bfeda
Compare
On AIX, building |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/7121 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/151/builds/2794 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/17/builds/3320 Here is the relevant piece of the build log for the reference |
DanielCChen
added a commit
to DanielCChen/llvm-project
that referenced
this pull request
Oct 16, 2024
in favor of LLVM_ENABLE_RUNTIMES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in favor of LLVM_ENABLE_RUNTIMES