[MLIR] Fix: cast were meant to be dyn_cast.
#110518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benoit Jacob <[email protected]>
bjacob
changed the title
cast were meant to be dyn_cast.cast were meant to be dyn_cast.
|
@llvm/pr-subscribers-mlir-affine @llvm/pr-subscribers-mlir Author: Benoit Jacob (bjacob) ChangesThis fixes Full diff: https://github.com/llvm/llvm-project/pull/110518.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/Affine/IR/AffineOps.cpp b/mlir/lib/Dialect/Affine/IR/AffineOps.cpp
index 1ccff7324f514d..5e7a6b6ca883c3 100644
--- a/mlir/lib/Dialect/Affine/IR/AffineOps.cpp
+++ b/mlir/lib/Dialect/Affine/IR/AffineOps.cpp
@@ -4612,12 +4612,12 @@ struct DropDelinearizeOfSingleLoop
return failure();
// Check that the `linear_index` is an induction variable.
- auto inductionVar = cast<BlockArgument>(delinearizeOp.getLinearIndex());
+ auto inductionVar = dyn_cast<BlockArgument>(delinearizeOp.getLinearIndex());
if (!inductionVar)
return failure();
// Check that the parent is a `LoopLikeOpInterface`.
- auto loopLikeOp = cast<LoopLikeOpInterface>(
+ auto loopLikeOp = dyn_cast<LoopLikeOpInterface>(
inductionVar.getParentRegion()->getParentOp());
if (!loopLikeOp)
return failure();
|
kuhar
approved these changes
Sep 30, 2024
bjacob
added a commit
to iree-org/iree
that referenced
this pull request
Sep 30, 2024
Cherry-picks: 1. Cherry-picking llvm/llvm-project#110518 Carrying two local reverts: 1. Revert llvm/llvm-project#100667) - As noted by @hanhanW on #18619, that PR "breaks the stablehlo build. We need to wait stablehlo bumping LLVM ahead of it and fix the issue. Then we can bump stablehlo and drop the local commit together." 2. Revert llvm/llvm-project#110170) - That is just the Bazel change accompanying 1. Signed-off-by: Benoit Jacob <[email protected]>
|
Can we have a test that fails these? |
|
Correct, this was caught by IREE tests, so we are missing that coverage upstream. I'll send something. |
bjacob
added a commit
that referenced
this pull request
Oct 1, 2024
puja2196
pushed a commit
to puja2196/LLVM-tutorial
that referenced
this pull request
Oct 2, 2024
llvm/llvm-project#110518 fixed assertion failures in `cast` introduced in llvm/llvm-project#108450. Signed-off-by: Benoit Jacob <[email protected]>
Sterling-Augustine
pushed a commit
to Sterling-Augustine/llvm-project
that referenced
this pull request
Oct 3, 2024
llvm#110518 fixed assertion failures in `cast` introduced in llvm#108450. Signed-off-by: Benoit Jacob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
cast's that were introduced in #108450.