[libc++] Run additional LLDB data formatters tests as part of libc++'s CI #110570
Conversation
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) ChangesFull diff: https://github.com/llvm/llvm-project/pull/110570.diff 1 Files Affected:
diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot
index b0533cb9a49c93..1bd27eb344e8f7 100755
--- a/libcxx/utils/ci/run-buildbot
+++ b/libcxx/utils/ci/run-buildbot
@@ -371,7 +371,14 @@ bootstrapping-build)
-DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests"
echo "+++ Running the LLDB libc++ data formatter tests"
- ${NINJA} -vC "${BUILD_DIR}" check-lldb-api-functionalities-data-formatter-data-formatter-stl-libcxx
+ ${NINJA} -vC "${BUILD_DIR}" check-lldb-api-functionalities-data-formatter-data-formatter-stl-libcxx \
+ check-lldb-api-functionalities-data-formatter-data-formatter-stl-generic \
+ check-lldb-api-functionalities-data-formatter-data-formatter-stl-libcxx-simulators \
+ check-lldb-api-commands-expression-import-std-module \
+ check-lldb-api-lang-cpp-std-function-step-into-callable \
+ check-lldb-api-lang-cpp-std-function-recognizer \
+ check-lldb-api-lang-cpp-std-invoke-recognizer
+
echo "--- Running the libc++ and libc++abi tests"
${NINJA} -vC "${BUILD_DIR}" check-runtimes
|
|
@Michael137 Otherwise, would it make sense to define a target in LLDB that would build all the tests that are relevant for libc++ integration? We could just build that target and you folks can add things to it when needed. |
|
Thanks for the quick change!
I think that's a great idea. How about we land this change to get some immediate extra coverage and I'll open an issue on me to consolidate these into a single target? |
|
Expectedly the Which is good. That means we got extra coverage |
|
Merging despite the CI failure since the test that broke is exactly the one that we fixed by reverting #110355. |
|
FYI, trying to add the consolidated target here: #110856 |
…0856) We've been increasing the coverage of libc++ LLDB tests in the pre-merge CI (see #110570). Unfortunately the tests are spread across different targets. It would be great if we had a single target that libc++ maintainers could run. We do this by passing the `libc++` test-category as a parameter to LLDB's [`dotest` testing framework](https://lldb.llvm.org/resources/test.html). This will only run LLDB tests that have been marked as belonging to the `libc++` category.
No description provided.