[Clang][NFC] Add a test for CWG 2913 #110614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I marked DR2913 as implemented in 915df1a, but I forgot to add a corresponding test, so running the script would fail thereafter.
zyn0217
added
clang:frontend
|
@llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) ChangesI marked DR2913 as implemented in 915df1a, but I forgot to add a corresponding test, so running the script would fail thereafter. Full diff: https://github.com/llvm/llvm-project/pull/110614.diff 1 Files Affected:
diff --git a/clang/test/CXX/drs/cwg29xx.cpp b/clang/test/CXX/drs/cwg29xx.cpp
index e55e8e35e86f28..1b086ba979ec51 100644
--- a/clang/test/CXX/drs/cwg29xx.cpp
+++ b/clang/test/CXX/drs/cwg29xx.cpp
@@ -6,6 +6,26 @@
// RUN: %clang_cc1 -std=c++23 -pedantic-errors -verify=expected %s
// RUN: %clang_cc1 -std=c++2c -pedantic-errors -verify=expected %s
+namespace cwg2913 { // cwg2913: 20
+
+#if __cplusplus >= 202002L
+
+template<typename T>
+struct R {
+ R(T);
+ R(T, T);
+};
+
+template<typename T>
+R(T) -> R<T> requires true;
+
+template<typename T>
+R(T, T) requires true -> R<T>; // expected-error {{expected function body after function declarator}}
+
+#endif
+
+} // namespace cwg2913
+
namespace cwg2915 { // cwg2915: 20 tentatively ready 2024-08-16
#if __cplusplus >= 202302L
struct A {
|
|
I'm merging now - feel free to do any post-commit review. |
Endilll
reviewed
Oct 1, 2024
| R(T) -> R<T> requires true; | ||
|
|
||
| template<typename T> | ||
| R(T, T) requires true -> R<T>; // expected-error {{expected function body after function declarator}} |
There was a problem hiding this comment.
Can we make this diagnostic more friendly and actionable by stating that requires clause goes after the trailing return type, possibly suggesting a fix?
There was a problem hiding this comment.
Good idea, I’ll give it a try tomorrow
Sterling-Augustine
pushed a commit
to Sterling-Augustine/llvm-project
that referenced
this pull request
Oct 3, 2024
I marked DR2913 as implemented in 915df1a, but I forgot to add a corresponding test, so running the script would fail thereafter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I marked DR2913 as implemented in 915df1a, but I forgot to add a corresponding test, so running the script would fail thereafter.