[NFC] Make 'Triple&' param a 'const&' instead

[Sirraide]

There isn’t really a reason for it not to be a const& (afaict), and it is a bit annoying because some APIs (e.g. TargetMachine::getTargetTriple()) return a const Triple&.

[llvmbot]

@llvm/pr-subscribers-llvm-binary-utilities

Author: None (Sirraide)

Changes

There isn’t really a reason for it not to be a const& (afaict), and it is a bit annoying because some APIs (e.g. TargetMachine::getTargetTriple()) return a const Triple&.

---

Full diff: https://github.com/llvm/llvm-project/pull/110628.diff

2 Files Affected:

• (modified) llvm/include/llvm/Object/Archive.h (+1-1)
• (modified) llvm/lib/Object/Archive.cpp (+1-1)

diff --git a/llvm/include/llvm/Object/Archive.h b/llvm/include/llvm/Object/Archive.h
index a3165c3235e0ed..b2dd970b00c056 100644
--- a/llvm/include/llvm/Object/Archive.h
+++ b/llvm/include/llvm/Object/Archive.h
@@ -339,7 +339,7 @@ class Archive : public Binary {
   Kind kind() const { return (Kind)Format; }
   bool isThin() const { return IsThin; }
   static object::Archive::Kind getDefaultKind();
-  static object::Archive::Kind getDefaultKindForTriple(Triple &T);
+  static object::Archive::Kind getDefaultKindForTriple(const Triple &T);
 
   child_iterator child_begin(Error &Err, bool SkipInternal = true) const;
   child_iterator child_end() const;
diff --git a/llvm/lib/Object/Archive.cpp b/llvm/lib/Object/Archive.cpp
index e798bbdd16f143..9857eb0de7a80d 100644
--- a/llvm/lib/Object/Archive.cpp
+++ b/llvm/lib/Object/Archive.cpp
@@ -969,7 +969,7 @@ Archive::Archive(MemoryBufferRef Source, Error &Err)
   Err = Error::success();
 }
 
-object::Archive::Kind Archive::getDefaultKindForTriple(Triple &T) {
+object::Archive::Kind Archive::getDefaultKindForTriple(const Triple &T) {
   if (T.isOSDarwin())
     return object::Archive::K_DARWIN;
   if (T.isOSAIX())

[nikic]

LGTM

[Sirraide]

CI errors seem to be because of something in Bolt; I’m gonna go ahead and assume that that’s unrelated and that I just need to update my fork again because I candidly don’t see how this could possibly cause those...