Skip to content

[LLD][COFF] Define remaining ARM64EC builtin symbols #110640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

cjacek
Copy link
Contributor

@cjacek cjacek commented Oct 1, 2024

__arm64x_native_entrypoint and __guard_check_icall_a64n_fptr are relevant only for hybrid ARM64X images, we need support for separate namespaces before we can support them.

__hybrid_image_info_bitfield is 0 in MSVC linker in all tests I tried.

__arm64x_native_entrypoint and __guard_check_icall_a64n_fptr are relevant only
for hybrid ARM64X images, we need support for separate namespaces before we can
support them.

__hybrid_image_info_bitfield is 0 in MSVC linker in all tests I tried.
@cjacek cjacek requested a review from mstorsjo October 1, 2024 09:18
@cjacek
Copy link
Contributor Author

cjacek commented Oct 1, 2024

With this PR, support for non-hybrid (ARM64X) CHPE metadata is complete. The main remaining tasks for linking CRT are handling anti-dependency symbols and adding EC mangling awareness in the symbol table.

Copy link
Member

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjacek cjacek merged commit ba340b2 into llvm:main Oct 1, 2024
9 checks passed
@cjacek cjacek deleted the arm64ec-syms branch October 1, 2024 12:28
Sterling-Augustine pushed a commit to Sterling-Augustine/llvm-project that referenced this pull request Oct 3, 2024
__arm64x_native_entrypoint and __guard_check_icall_a64n_fptr are
relevant only for hybrid ARM64X images, we need support for separate
namespaces before we can support them.

__hybrid_image_info_bitfield is 0 in MSVC linker in all tests I tried.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants