[AMDGPU] Remember to clear a DenseMap between runs of SIInsertWaitcnts #110650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused nondeterministic codegen in some cases.
arsenm
approved these changes
Oct 1, 2024
|
@llvm/pr-subscribers-backend-amdgpu Author: Jay Foad (jayfoad) ChangesThis caused nondeterministic codegen in some cases. Full diff: https://github.com/llvm/llvm-project/pull/110650.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp b/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
index 80a7529002ac90..b2cfc3f3172564 100644
--- a/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
+++ b/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
@@ -2598,6 +2598,7 @@ bool SIInsertWaitcnts::runOnMachineFunction(MachineFunction &MF) {
Modified = true;
}
ReleaseVGPRInsts.clear();
+ PreheadersToFlush.clear();
SLoadAddresses.clear();
return Modified;
|
Sterling-Augustine
pushed a commit
to Sterling-Augustine/llvm-project
that referenced
this pull request
Oct 3, 2024
llvm#110650) This caused nondeterministic codegen in some cases.
qiaojbao
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Oct 31, 2024
This includes a cherry-pick of llvm#110650 This includes a cherry-pick of llvm#110818 Change-Id: I95b223ab1eb575465d96502b2cf69b95f994ad8a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused nondeterministic codegen in some cases.