[scudo] Fix isOwned on MTE devices. #110717
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If called on address that is actually not owned, the tags could not match. Disable tag checks in isOwned().
llvmbot
added
compiler-rt
compiler-rt:scudo
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Evgenii Stepanov (eugenis) ChangesIf called on address that is actually not owned, the tags could not match. Disable tag checks in isOwned(). Full diff: https://github.com/llvm/llvm-project/pull/110717.diff 1 Files Affected:
diff --git a/compiler-rt/lib/scudo/standalone/combined.h b/compiler-rt/lib/scudo/standalone/combined.h
index a5f1bc388e8824..88fdc5943d6f81 100644
--- a/compiler-rt/lib/scudo/standalone/combined.h
+++ b/compiler-rt/lib/scudo/standalone/combined.h
@@ -785,6 +785,8 @@ class Allocator {
// A corrupted chunk will not be reported as owned, which is WAI.
bool isOwned(const void *Ptr) {
initThreadMaybe();
+ // If the allocation is not owned, the tags could be wrong.
+ ScopedDisableMemoryTagChecks x;
#ifdef GWP_ASAN_HOOKS
if (GuardedAlloc.pointerIsMine(Ptr))
return true;
|
fmayer
approved these changes
Oct 1, 2024
ChiaHungDuan
approved these changes
Oct 1, 2024
|
The problem was reading the header in Chunk::isValid. If you check the test for isOwned, the buffer for that is stack allocated, and not guaranteed to have any specific tag. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/4583 Here is the relevant piece of the build log for the reference |
chapuni
added a commit
that referenced
this pull request
Oct 2, 2024
This caused failures in aarch64 builders. This reverts commit 98c9523. (llvmorg-20-init-7659-g98c9523113b5)
|
Excuse me, I have reverted this. See, https://lab.llvm.org/buildbot/#/builders/51/builds/4583 |
Sterling-Augustine
pushed a commit
to Sterling-Augustine/llvm-project
that referenced
this pull request
Oct 3, 2024
If called on an address that is actually not owned, the header tag might not match. This would cause an MTE fault in Chunk::isValid. Disable tag checks in isOwned().
Sterling-Augustine
pushed a commit
to Sterling-Augustine/llvm-project
that referenced
this pull request
Oct 3, 2024
This caused failures in aarch64 builders. This reverts commit 98c9523. (llvmorg-20-init-7659-g98c9523113b5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If called on address that is actually not owned, the tags could not match. Disable tag checks in isOwned().