Skip to content

[llvm-debuginfod-find] Fix help text regression #110752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

Prabhuk
Copy link
Contributor

@Prabhuk Prabhuk commented Oct 1, 2024

While porting the tool from using cl:opt to OptTable, I had mistakenly
deleted the help text header that was originally part of the tool.
Bringing it back in this patch.

While porting the tool from using cl:opt to OptTable, I had mistakenly
deleted the help text header that was originally part of the tool.
Bringing it back in this patch.
@llvmbot
Copy link
Member

llvmbot commented Oct 1, 2024

@llvm/pr-subscribers-debuginfo

Author: Prabhuk (Prabhuk)

Changes

While porting the tool from using cl:opt to OptTable, I had mistakenly
deleted the help text header that was originally part of the tool.
Bringing it back in this patch.


Full diff: https://github.com/llvm/llvm-project/pull/110752.diff

1 Files Affected:

  • (modified) llvm/tools/llvm-debuginfod-find/llvm-debuginfod-find.cpp (+7-1)
diff --git a/llvm/tools/llvm-debuginfod-find/llvm-debuginfod-find.cpp b/llvm/tools/llvm-debuginfod-find/llvm-debuginfod-find.cpp
index 699fcf8a7dbcd6..e3f3a82d7636cc 100644
--- a/llvm/tools/llvm-debuginfod-find/llvm-debuginfod-find.cpp
+++ b/llvm/tools/llvm-debuginfod-find/llvm-debuginfod-find.cpp
@@ -79,7 +79,13 @@ static void parseArgs(int argc, char **argv) {
   if (Args.hasArg(OPT_help)) {
     Tbl.printHelp(llvm::outs(),
                   "llvm-debuginfod-find [options] <input build_id>",
-                  ToolName.str().c_str());
+                   "llvm-debuginfod-find: Fetch debuginfod artifacts\n\n"
+      "This program is a frontend to the debuginfod client library. The cache "
+      "directory, request timeout (in seconds), and debuginfod server urls are "
+      "set by these environment variables:\n"
+      "DEBUGINFOD_CACHE_PATH (default set by sys::path::cache_directory)\n"
+      "DEBUGINFOD_TIMEOUT (defaults to 90s)\n"
+      "DEBUGINFOD_URLS=[comma separated URLs] (defaults to empty)\n");
     std::exit(0);
   }
 

@Prabhuk Prabhuk requested a review from mysterymath October 1, 2024 21:58
@Prabhuk Prabhuk merged commit ab83d31 into llvm:main Oct 2, 2024
8 checks passed
@dwblaikie
Copy link
Collaborator

Could add test coverage for this, but might not be all that interesting.

Sterling-Augustine pushed a commit to Sterling-Augustine/llvm-project that referenced this pull request Oct 3, 2024
While porting the tool from using cl:opt to OptTable, I had mistakenly
deleted the help text header that was originally part of the tool.
Bringing it back in this patch.
@Prabhuk Prabhuk deleted the llvm-debuginfod-find-helptext branch May 14, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants