[lldb-dap] Disable TestDAP_optimized under ASAN #111063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb Author: Augusto Noronha (augusto2112) ChangesFull diff: https://github.com/llvm/llvm-project/pull/111063.diff 1 Files Affected:
diff --git a/lldb/test/API/tools/lldb-dap/optimized/TestDAP_optimized.py b/lldb/test/API/tools/lldb-dap/optimized/TestDAP_optimized.py
index 42a95de309a08b..ae144ebdca46bd 100644
--- a/lldb/test/API/tools/lldb-dap/optimized/TestDAP_optimized.py
+++ b/lldb/test/API/tools/lldb-dap/optimized/TestDAP_optimized.py
@@ -28,6 +28,7 @@ def test_stack_frame_name(self):
parent_frame = self.dap_server.get_stackFrame(frameIndex=1)
self.assertTrue(parent_frame["name"].endswith(" [opt]"))
+ @skipIfAsan # On ASAN builds this test intermittently fails https://github.com/llvm/llvm-project/issues/111061
@skipIfWindows
def test_optimized_variable(self):
"""Test optimized variable value contains error."""
|
augusto2112
force-pushed
the
disable-testdap
branch
from
bf8750b to
61c25e5
Compare
augusto2112
changed the title
This test is failing on green dragon and I couldn't figure out why, disabling it for now under ASAN to get the bot green. Opened an issue (llvm#111061) to track the problem.
augusto2112
force-pushed
the
disable-testdap
branch
from
61c25e5 to
9f64a45
Compare
You can test this locally with the following command:darker --check --diff -r 000e790be35b77a01872851646d54432a203542c...9f64a452745b070b610e583436f074b3f9a24f4f lldb/test/API/tools/lldb-dap/optimized/TestDAP_optimized.pyView the diff from darker here.--- TestDAP_optimized.py 2024-10-03 20:45:49.000000 +0000
+++ TestDAP_optimized.py 2024-10-03 20:50:17.743555 +0000
@@ -26,11 +26,11 @@
leaf_frame = self.dap_server.get_stackFrame(frameIndex=0)
self.assertTrue(leaf_frame["name"].endswith(" [opt]"))
parent_frame = self.dap_server.get_stackFrame(frameIndex=1)
self.assertTrue(parent_frame["name"].endswith(" [opt]"))
- @skipIfAsan # On ASAN builds this test intermittently fails https://github.com/llvm/llvm-project/issues/111061
+ @skipIfAsan # On ASAN builds this test intermittently fails https://github.com/llvm/llvm-project/issues/111061
@skipIfWindows
def test_optimized_variable(self):
"""Test optimized variable value contains error."""
program = self.getBuildArtifact("a.out")
self.build_and_launch(program)
|
adrian-prantl
pushed a commit
to adrian-prantl/llvm-project
that referenced
this pull request
Dec 20, 2024
This test is failing on green dragon and I couldn't figure out why, disabling it for now under ASAN to get the bot green. Opened an issue (llvm#111061) to track the problem. (cherry picked from commit 47ff13b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is failing on green dragon and I couldn't figure out why,
disabling it for now under ASAN to get the bot green.
Opened an issue (#111061) to track the problem.