Skip to content

[SandboxIR] Switch more Instruction::create() functions to InsertPosition #111075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

vporpo
Copy link
Contributor

@vporpo vporpo commented Oct 3, 2024

No description provided.

@@ -2891,7 +2891,8 @@ define void @foo(i1 %cond0, i1 %cond2) {

{
// Check unconditional BranchInst::create() InsertBefore.
auto *Br = sandboxir::BranchInst::create(BB1, /*InsertBefore=*/Ret1, Ctx);
auto *Br = sandboxir::BranchInst::create(
BB1, /*InsertBefore=*/Ret1->getIterator(), Ctx);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The /*InsertBefore=*/ comment should now be /*InsertPosition=*/, right? Same for other occurrences in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, there are a couple of them left, I forgot to fix them, thanks for noticing it!

@vporpo vporpo merged commit e1434a8 into llvm:main Oct 4, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants