MLIR BUILD.bazel: fold BasicPtxBuilderInterface into NVVMDialect
#111172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benoit Jacob <[email protected]>
|
(To be clear, this fixes Bazel build breakage already present upstream, not just downstream. Here is a downstream CI run that's fixed by this PR: https://github.com/iree-org/iree/actions/runs/11182717531/job/31089636040?pr=18696) |
hanhanW
approved these changes
Oct 4, 2024
bjacob
added a commit
to iree-org/iree
that referenced
this pull request
Oct 4, 2024
One cherry-pick: llvm/llvm-project#111172. Signed-off-by: Benoit Jacob <[email protected]>
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing an integrate into downstream https://github.com/iree-org/iree, I ran into a typical Bazel error with
BasicPtxBuilderInterface.cppincludingNVVMDialect.hwhich was not exposed as a header by a declared dependency. I tried fixing this the straightforward way, by letting:BasicPtxBuilderInterfacedepend on:NVVMDialect, but that caused another Bazel error: circular dependency between these two targets, as:NVVMDialectwas already depending on:BasicPtxBuilderInterface. I tried breaking that circle by dropping the latter dependency, but it was a real dependency in the code, specifically in the TableGen-generated code. So in the end it seems that these two targets just need to be fused, which this PR does.