[Flang][OpenMP] Add some semantic checks for Linear clause #111354

Thirumalai-Shaktivel · 2024-10-07T10:18:00Z

This PR adds all the missing semantics for the Linear clause based on the OpenMP 5.2 restrictions. The restriction details are mentioned below.

OpenMP 5.2:
5.4.6 linear Clause restrictions

A linear-modifier may be specified as ref or uval only on a declare simd directive.
If linear-modifier is not ref, all list items must be of type integer.
If linear-modifier is ref or uval, all list items must be dummy arguments without the VALUE attribute.
List items must not be Cray pointers or variables that have the POINTER attribute. Cray pointer support has been deprecated.
If linear-modifier is ref, list items must be polymorphic variables, assumed-shape arrays, or variables with the ALLOCATABLE attribute.
A common block name must not appear in a linear clause.
The list-item cannot appear more than once

4.4.4 ordered Clause restriction

If n is explicitly specified, a linear clause must not be specified on the same directive.

5.11 aligned Clause restriction

Each list item must have C_PTR or Cray pointer type or have the POINTER or ALLOCATABLE attribute. Cray pointer support has been deprecated.

… on the OpenMP 5.2 restrictions

…use with (n) is specified

llvmbot · 2024-10-07T10:18:23Z

@llvm/pr-subscribers-flang-openmp

@llvm/pr-subscribers-flang-semantics

Author: Thirumalai Shaktivel (Thirumalai-Shaktivel)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/111354.diff

3 Files Affected:

(modified) flang/lib/Semantics/check-omp-structure.cpp (+114-4)
(modified) flang/test/Semantics/OpenMP/declarative-directive.f90 (+1)
(added) flang/test/Semantics/OpenMP/linear-cluase01.f90 (+50)

diff --git a/flang/lib/Semantics/check-omp-structure.cpp b/flang/lib/Semantics/check-omp-structure.cpp
index 5ef504aa72326e..d409d7b548767e 100644
--- a/flang/lib/Semantics/check-omp-structure.cpp
+++ b/flang/lib/Semantics/check-omp-structure.cpp
@@ -303,6 +303,30 @@ void OmpStructureChecker::CheckMultListItems() {
     CheckMultipleOccurrence(
         listVars, nontempNameList, itr->second->source, "NONTEMPORAL");
   }
+
+  // Linear clause
+  auto linearClauses{FindClauses(llvm::omp::Clause::OMPC_linear)};
+  for (auto itr = linearClauses.first; itr != linearClauses.second; ++itr) {
+    const auto &linearClause{
+        std::get<parser::OmpClause::Linear>(itr->second->u)};
+    std::list<parser::Name> nameList;
+    common::visit(
+        common::visitors{
+            [&](const parser::OmpLinearClause::WithoutModifier
+                    &withoutModifier) {
+              for (const auto &name : withoutModifier.names) {
+                nameList.push_back(name);
+              }
+            },
+            [&](const parser::OmpLinearClause::WithModifier &withModifier) {
+              for (const auto &name : withModifier.names) {
+                nameList.push_back(name);
+              }
+            },
+        },
+        linearClause.v.u);
+    CheckMultipleOccurrence(listVars, nameList, itr->second->source, "LINEAR");
+  }
 }
 
 bool OmpStructureChecker::HasInvalidWorksharingNesting(
@@ -2256,11 +2280,12 @@ void OmpStructureChecker::Leave(const parser::OmpClauseList &) {
         }
       }
     }
-    // Sema checks related to presence of multiple list items within the same
-    // clause
-    CheckMultListItems();
   } // SIMD
 
+  // Semantics checks related to presence of multiple list items within the same
+  // clause
+  CheckMultListItems();
+
   // 2.7.3 Single Construct Restriction
   if (GetContext().directive == llvm::omp::Directive::OMPD_end_single) {
     CheckNotAllowedIfClause(
@@ -2975,16 +3000,101 @@ void OmpStructureChecker::Enter(const parser::OmpClause::If &x) {
 void OmpStructureChecker::Enter(const parser::OmpClause::Linear &x) {
   CheckAllowedClause(llvm::omp::Clause::OMPC_linear);
 
+  parser::CharBlock source = GetContext().clauseSource;
   // 2.7 Loop Construct Restriction
   if ((llvm::omp::allDoSet | llvm::omp::allSimdSet)
           .test(GetContext().directive)) {
     if (std::holds_alternative<parser::OmpLinearClause::WithModifier>(x.v.u)) {
-      context_.Say(GetContext().clauseSource,
+      context_.Say(source,
           "A modifier may not be specified in a LINEAR clause "
           "on the %s directive"_err_en_US,
           ContextDirectiveAsFortran());
+      return;
+    }
+  }
+
+  // 4.4.4 Ordered clause restriction
+  if (const auto *clause{
+          FindClause(GetContext(), llvm::omp::Clause::OMPC_ordered)}) {
+    const auto &orderedClause{std::get<parser::OmpClause::Ordered>(clause->u)};
+    if (orderedClause.v) {
+      return;
     }
   }
+
+  auto checkForValidLinearClaue = [&](const parser::Name &name, bool is_ref) {
+    parser::CharBlock source = GetContext().clauseSource;
+    std::string list_item_name = name.ToString();
+    if (!is_ref && !name.symbol->GetType()->IsNumeric(TypeCategory::Integer)) {
+      context_.Say(source,
+          "The list item `%s` specified with other than linear-modifier `REF`"
+          " must be of type INTEGER"_err_en_US,
+          list_item_name);
+    }
+    if (GetContext().directive == llvm::omp::Directive::OMPD_declare_simd &&
+        !IsDummy(*name.symbol)) {
+      context_.Say(source,
+          "The list item `%s` must be a dummy argument"_err_en_US,
+          list_item_name);
+    }
+    if (IsPointer(*name.symbol) ||
+        name.symbol->test(Symbol::Flag::CrayPointer)) {
+      context_.Say(source,
+          "The list item `%s` in a LINEAR clause must not be Cray Pointer "
+          "or a variable with POINTER attribute"_err_en_US,
+          list_item_name);
+    }
+    if (FindCommonBlockContaining(*name.symbol)) {
+      context_.Say(source,
+          "'%s' is a common block name and must not appear in an "
+          "LINEAR clause"_err_en_US,
+          list_item_name);
+    }
+  };
+
+  // 5.4.6 Linear clause Restrictions
+  common::visit(
+      common::visitors{
+          [&](const parser::OmpLinearClause::WithoutModifier &withoutModifier) {
+            for (const auto &name : withoutModifier.names) {
+              if (name.symbol) {
+                checkForValidLinearClaue(name, false);
+              }
+            }
+          },
+          [&](const parser::OmpLinearClause::WithModifier &withModifier) {
+            for (const auto &name : withModifier.names) {
+              if (name.symbol) {
+                checkForValidLinearClaue(name,
+                    (withModifier.modifier.v ==
+                        parser::OmpLinearModifier::Type::Ref));
+                std::string list_item_name = name.ToString();
+                if (withModifier.modifier.v !=
+                        parser::OmpLinearModifier::Type::Val &&
+                    IsDummy(*name.symbol) && IsValue(*name.symbol)) {
+                  context_.Say(source,
+                      "The list item `%s` specified with the linear-modifier "
+                      "`REF` or `UVAL` must be a dummy argument without "
+                      "`VALUE` attribute"_err_en_US,
+                      list_item_name);
+                }
+                if (withModifier.modifier.v ==
+                        parser::OmpLinearModifier::Type::Ref &&
+                    !(IsAllocatable(*name.symbol) ||
+                        IsAssumedShape(*name.symbol) ||
+                        IsPolymorphic(*name.symbol))) {
+                  context_.Say(source,
+                      "The list item `%s` specified with the linear-modifier "
+                      "`REF` must be polymorphic variable, assumed-shape "
+                      "array, "
+                      "or a variable with the `ALLOCATABLE` attribute"_err_en_US,
+                      list_item_name);
+                }
+              }
+            }
+          },
+      },
+      x.v.u);
 }
 
 void OmpStructureChecker::CheckAllowedMapTypes(
diff --git a/flang/test/Semantics/OpenMP/declarative-directive.f90 b/flang/test/Semantics/OpenMP/declarative-directive.f90
index 8d6762b87adb95..17dc50b70e5421 100644
--- a/flang/test/Semantics/OpenMP/declarative-directive.f90
+++ b/flang/test/Semantics/OpenMP/declarative-directive.f90
@@ -23,6 +23,7 @@ end subroutine requires_2
 
 subroutine declare_simd_1(a, b)
   real(8), intent(inout) :: a, b
+  !ERROR: 'a' in ALIGNED clause must be of type C_PTR, POINTER or ALLOCATABLE
   !$omp declare simd(declare_simd_1) aligned(a)
   a = 3.14 + b
 end subroutine declare_simd_1
diff --git a/flang/test/Semantics/OpenMP/linear-cluase01.f90 b/flang/test/Semantics/OpenMP/linear-cluase01.f90
new file mode 100644
index 00000000000000..a56709aae7ad73
--- /dev/null
+++ b/flang/test/Semantics/OpenMP/linear-cluase01.f90
@@ -0,0 +1,50 @@
+! REQUIRES: openmp_runtime
+! RUN: %python %S/../test_errors.py %s %flang_fc1 %openmp_flags
+! OpenMP Version 5.2
+! Various checks for the linear clause
+! 5.4.6 `linear` Clause
+
+! Case 1
+subroutine linear_clause_01(arg)
+    integer, intent(in) :: arg(:)
+    !ERROR: A modifier may not be specified in a LINEAR clause on the DO directive
+    !$omp do linear(uval(arg))
+    do i = 1, 5
+        print *, arg(i)
+    end do
+end subroutine linear_clause_01
+
+! Case 2
+subroutine linear_clause_02(arg_01, arg_02, arg_03)
+    !ERROR: The list item `arg_01` specified with other than linear-modifier `REF` must be of type INTEGER
+    !$omp declare simd linear(val(arg_01))
+    real, intent(in) :: arg_01(:)
+
+    !ERROR: The list item `arg_02` specified with the linear-modifier `REF` or `UVAL` must be a dummy argument without `VALUE` attribute
+    !$omp declare simd linear(uval(arg_02))
+    integer, value, intent(in) :: arg_02
+
+    !ERROR: The list item `arg_03` specified with other than linear-modifier `REF` must be of type INTEGER
+    !ERROR: The list item `arg_03` in a LINEAR clause must not be Cray Pointer or a variable with POINTER attribute
+    !$omp declare simd linear(arg_03)
+    real, pointer :: arg_03
+
+    !ERROR: The list item `var` must be a dummy argument
+    !ERROR: The list item `var` in a LINEAR clause must not be Cray Pointer or a variable with POINTER attribute
+    !$omp declare simd linear(uval(var))
+    integer, pointer :: var
+end subroutine linear_clause_02
+
+! Case 3
+subroutine linear_clause_03(arg)
+    integer, intent(in) :: arg
+    !ERROR: The list item `arg` specified with the linear-modifier `REF` must be polymorphic variable, assumed-shape array, or a variable with the `ALLOCATABLE` attribute
+    !ERROR: List item 'arg' present at multiple LINEAR clauses
+    !$omp declare simd linear(ref(arg)) linear(arg)
+
+    integer :: i
+    common /cc/ i
+    !ERROR: The list item `i` must be a dummy argument
+    !ERROR: 'i' is a common block name and must not appear in an LINEAR clause
+    !$omp declare simd linear(i)
+end subroutine linear_clause_03

kparzysz · 2024-10-07T15:58:46Z

flang/test/Semantics/OpenMP/linear-cluase01.f90

Typo: cluase -> clause.

kiranchandramohan

A few nit comments.

Could you expand the summary to list the checks implemented in the patch with a reference to the standard and section?

kiranchandramohan · 2024-10-07T16:13:16Z

flang/lib/Semantics/check-omp-structure.cpp

@@ -2975,16 +3000,101 @@ void OmpStructureChecker::Enter(const parser::OmpClause::If &x) {
 void OmpStructureChecker::Enter(const parser::OmpClause::Linear &x) {
  CheckAllowedClause(llvm::omp::Clause::OMPC_linear);

+  parser::CharBlock source = GetContext().clauseSource;


Use braced initialized in frontend code.

kiranchandramohan · 2024-10-07T16:13:43Z

flang/lib/Semantics/check-omp-structure.cpp

    }
  }
+
+  auto checkForValidLinearClaue = [&](const parser::Name &name, bool is_ref) {


Suggested change

auto checkForValidLinearClaue = [&](const parser::Name &name, bool is_ref) {

auto checkForValidLinearClause = [&](const parser::Name &name, bool is_ref) {

kiranchandramohan · 2024-10-07T16:17:15Z

flang/lib/Semantics/check-omp-structure.cpp

+
+  auto checkForValidLinearClaue = [&](const parser::Name &name, bool is_ref) {
+    parser::CharBlock source = GetContext().clauseSource;
+    std::string list_item_name = name.ToString();


Suggested change

std::string list_item_name = name.ToString();

std::string listItemName = name.ToString();

kiranchandramohan · 2024-10-07T16:19:50Z

flang/lib/Semantics/check-omp-structure.cpp

    }
  }
+
+  auto checkForValidLinearClaue = [&](const parser::Name &name, bool is_ref) {
+    parser::CharBlock source = GetContext().clauseSource;


Nit: Use braced initialization.

kiranchandramohan · 2024-10-07T16:23:42Z

flang/lib/Semantics/check-omp-structure.cpp

+                checkForValidLinearClaue(name,
+                    (withModifier.modifier.v ==
+                        parser::OmpLinearModifier::Type::Ref));
+                std::string list_item_name = name.ToString();


Suggested change

std::string list_item_name = name.ToString();

std::string listItemName = name.ToString();

kiranchandramohan · 2024-10-07T16:34:09Z

flang/lib/Semantics/check-omp-structure.cpp

+
+  // Linear clause
+  auto linearClauses{FindClauses(llvm::omp::Clause::OMPC_linear)};
+  for (auto itr = linearClauses.first; itr != linearClauses.second; ++itr) {


Suggested change

for (auto itr = linearClauses.first; itr != linearClauses.second; ++itr) {

for (auto itr{linearClauses.first}; itr != linearClauses.second; ++itr) {

Thirumalai-Shaktivel · 2024-10-09T05:29:02Z

flang/lib/Semantics/check-omp-structure.cpp

+          FindClause(GetContext(), llvm::omp::Clause::OMPC_ordered)}) {
+    const auto &orderedClause{std::get<parser::OmpClause::Ordered>(clause->u)};
+    if (orderedClause.v) {
+      return;


Flang-new already throws an error, Clause LINEAR is not allowed if clause ORDERED appears on the DO directive. So, I skipped here.

Thirumalai-Shaktivel · 2024-10-09T05:35:01Z

I addressed all the comments, @kiranchandramohan.

Thanks for the reviews.

OpenMP 5.2 restriction: Each list item must have C_PTR or Cray pointer type or have the POINTER or ALLOCATABLE attribute.

NimishMishra

One small comment on ALIGNED clause test added in this PR.

Ultra nit: "If n is explicitly specified, a linear clause must not be specified on the same directive" in description -> "If an ordered clause is explicitly specified......"

NimishMishra · 2024-10-09T05:44:34Z

flang/test/Semantics/OpenMP/declarative-directive.f90

@@ -23,6 +23,7 @@ end subroutine requires_2

 subroutine declare_simd_1(a, b)
  real(8), intent(inout) :: a, b
+  !ERROR: 'a' in ALIGNED clause must be of type C_PTR, POINTER or ALLOCATABLE


Do we also deal with ALIGNED clause in this PR? A similar issue is causing the Linux CI failure:

flang/test/Examples/omp-declarative-directive.f90:11:38: error: 'a' in ALIGNED clause must be of type C_PTR, POINTER or ALLOCATABLE -- | !$omp declare simd(declare_simd_1) aligned(a)

Yes, this line: https://github.com/llvm/llvm-project/pull/111354/files#diff-be225bc038e95a229024c9f227284112f98fe31762bc0bb80605de425aadd084R2287 is responsible for the change.

I fixed it in the recent commit.

kparzysz · 2024-12-02T16:18:51Z

flang/lib/Semantics/check-omp-structure.cpp

+  auto linearClauses{FindClauses(llvm::omp::Clause::OMPC_linear)};
+  for (auto itr{linearClauses.first}; itr != linearClauses.second; ++itr) {
+    const auto &linearClause{
+        std::get<parser::OmpClause::Linear>(itr->second->u)};


FindClauses now returns an iterator range, please use range-for here.

kparzysz · 2024-12-02T16:30:30Z

flang/lib/Semantics/check-omp-structure.cpp

+        common::visitors{
+            [&](const parser::OmpLinearClause::WithoutModifier
+                    &withoutModifier) {
+              for (const auto &name : withoutModifier.names) {
+                nameList.push_back(name);
+              }
+            },
+            [&](const parser::OmpLinearClause::WithModifier &withModifier) {
+              for (const auto &name : withModifier.names) {
+                nameList.push_back(name);
+              }
+            },
+        },


You can only have a single visitor, plus you can simplify the copy:

[&](auto &&s) { std::copy(s.names.begin(), s.names.end(), std::back_inserter(nameList)); }

kparzysz · 2024-12-02T16:34:23Z

flang/lib/Semantics/check-omp-structure.cpp

+          },
+          [&](const parser::OmpLinearClause::WithModifier &withModifier) {
+            for (const auto &name : withModifier.names) {
+              if (name.symbol) {


You can extract this into a lamda to reduce indentation.

kparzysz · 2024-12-02T16:35:04Z

flang/lib/Semantics/check-omp-structure.cpp

+                      "The list item `%s` specified with the linear-modifier "
+                      "`REF` or `UVAL` must be a dummy argument without "
+                      "`VALUE` attribute"_err_en_US,


Please concatenate messages into a single string. This is to make grepping for messages easier.

kparzysz · 2024-12-02T16:35:14Z

flang/lib/Semantics/check-omp-structure.cpp

+                      "The list item `%s` specified with the linear-modifier "
+                      "`REF` must be polymorphic variable, assumed-shape "
+                      "array, "
+                      "or a variable with the `ALLOCATABLE` attribute"_err_en_US,


kparzysz · 2024-12-02T16:38:00Z

I will change the modifier representation in LINEAR in a week or so. Please finish this soon, otherwise my code will create conflicts for you.

Thirumalai-Shaktivel · 2024-12-06T14:27:20Z

Thanks for the review, @kparzysz!

I addressed all the comments. If anything else to be done, please let me know.

github-actions · 2024-12-06T14:30:32Z

✅ With the latest revision this PR passed the C/C++ code formatter.

kparzysz

Almost ready, a few more comments.

kparzysz · 2024-12-06T14:40:49Z

flang/lib/Semantics/check-omp-structure.cpp

+            for (const auto &name : withoutModifier.names)
+              if (name.symbol)
+                checkForValidLinearClause_01(name, false);


Please add {} for nested statements.

Do you mean the following?

Suggested change

for (const auto &name : withoutModifier.names)

if (name.symbol)

checkForValidLinearClause_01(name, false);

for (const auto &name : withoutModifier.names) {

if (name.symbol) {

checkForValidLinearClause_01(name, false);

}

}

kparzysz · 2024-12-06T14:42:04Z

flang/lib/Semantics/check-omp-structure.cpp

+        common::visitors{
+            [&](const auto &u) {
+              std::copy(
+                  u.names.begin(), u.names.end(), std::back_inserter(nameList));
+            },
+        },


You only have one visitor, so you don't need common::visitors. Do common::visit([&]...).

kparzysz · 2024-12-06T14:43:44Z

flang/lib/Semantics/check-omp-structure.cpp

+  auto checkForValidLinearClause_01 = [&](const parser::Name &name,
+                                          bool is_ref) {


Please concatenate all error message strings in this function.

I'm sorry, but I'm not getting this.

Concatenate in the sense, for the following:

context_.Say(source, "The list item `%s` specified with other than linear-modifier `REF`" " must be of type INTEGER"_err_en_US, listItemName);

should I do?

context_.Say(source, "The list item `%s` specified with other than linear-modifier `REF` must be of type INTEGER"_err_en_US, listItemName);

kparzysz · 2024-12-06T14:43:53Z

flang/lib/Semantics/check-omp-structure.cpp

+  auto checkForValidLinearClause_02 =
+      [&](const parser::Name &name,
+          const parser::OmpLinearModifier::Value &modifierValue) {


Please concatenate all error message strings in this function.

kparzysz · 2024-12-06T15:13:35Z

Please don't use force-pushes. That messes up previous comments.

Thirumalai-Shaktivel · 2024-12-06T15:16:07Z

Sorry about that.

I rebased the commits and I had to force-push the changes.
Next time I will make sure not to rebase it.

Thirumalai-Shaktivel · 2024-12-06T15:22:13Z

Done.

Thirumalai-Shaktivel · 2024-12-07T03:07:58Z

Thank you!

Thirumalai-Shaktivel added 3 commits October 7, 2024 10:15

[LLVM-Flang][OpenMP] Add some semantic checks for Linear clause based…

617b8bf

… on the OpenMP 5.2 restrictions

[LLVM-Flang][OpenMP] Skip Linear clause semantic check if ordered cla…

7a7ebee

…use with (n) is specified

[Test] Add a test and update a check

f1a28c4

Thirumalai-Shaktivel added flang Flang issues not falling into any other category flang:openmp flang:semantics labels Oct 7, 2024

Thirumalai-Shaktivel requested a review from kiranchandramohan October 7, 2024 10:18

Thirumalai-Shaktivel requested review from tblah, harishch4, NimishMishra, kiranktp and kaviya2510 October 7, 2024 10:18

kparzysz reviewed Oct 7, 2024

View reviewed changes

kiranchandramohan reviewed Oct 7, 2024

View reviewed changes

Thirumalai-Shaktivel marked this pull request as draft October 8, 2024 11:41

Thirumalai-Shaktivel force-pushed the amd/linear_01 branch 2 times, most recently from 5922503 to 7a760f0 Compare October 9, 2024 05:15

Thirumalai-Shaktivel commented Oct 9, 2024

View reviewed changes

[Test] Fix a test to be valid

4c63c16

OpenMP 5.2 restriction: Each list item must have C_PTR or Cray pointer type or have the POINTER or ALLOCATABLE attribute.

Thirumalai-Shaktivel force-pushed the amd/linear_01 branch from 7a760f0 to 599b31f Compare October 9, 2024 05:43

NimishMishra reviewed Oct 9, 2024

View reviewed changes

Thirumalai-Shaktivel marked this pull request as ready for review October 9, 2024 05:57

Thirumalai-Shaktivel requested review from kiranchandramohan and kparzysz October 16, 2024 03:05

Thirumalai-Shaktivel force-pushed the amd/linear_01 branch from 599b31f to b67a77d Compare October 21, 2024 08:15

kparzysz reviewed Dec 2, 2024

View reviewed changes

Thirumalai-Shaktivel force-pushed the amd/linear_01 branch from b67a77d to 37458b5 Compare December 6, 2024 14:26

Thirumalai-Shaktivel force-pushed the amd/linear_01 branch from 37458b5 to 82cf1bd Compare December 6, 2024 14:43

kparzysz reviewed Dec 6, 2024

View reviewed changes

Thirumalai-Shaktivel force-pushed the amd/linear_01 branch from 82cf1bd to 4c63c16 Compare December 6, 2024 15:21

kparzysz approved these changes Dec 6, 2024

View reviewed changes

kparzysz merged commit e73ec1a into llvm:main Dec 6, 2024
8 checks passed

Thirumalai-Shaktivel deleted the amd/linear_01 branch December 7, 2024 03:07

	auto checkForValidLinearClaue = [&](const parser::Name &name, bool is_ref) {
	auto checkForValidLinearClause = [&](const parser::Name &name, bool is_ref) {

	std::string list_item_name = name.ToString();
	std::string listItemName = name.ToString();

	for (auto itr = linearClauses.first; itr != linearClauses.second; ++itr) {
	for (auto itr{linearClauses.first}; itr != linearClauses.second; ++itr) {

		auto checkForValidLinearClause_01 = [&](const parser::Name &name,
		bool is_ref) {

[Flang][OpenMP] Add some semantic checks for Linear clause #111354

[Flang][OpenMP] Add some semantic checks for Linear clause #111354

Uh oh!

Conversation

Thirumalai-Shaktivel commented Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

llvmbot commented Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kiranchandramohan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Thirumalai-Shaktivel commented Oct 9, 2024

Uh oh!

NimishMishra left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kparzysz commented Dec 2, 2024

Uh oh!

Thirumalai-Shaktivel commented Dec 6, 2024

Uh oh!

github-actions bot commented Dec 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kparzysz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Thirumalai-Shaktivel commented Oct 7, 2024 •

edited

Loading

llvmbot commented Oct 7, 2024 •

edited

Loading

github-actions bot commented Dec 6, 2024 •

edited

Loading