Skip to content

Added include of common interfaces #111374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gbMattN
Copy link
Contributor

@gbMattN gbMattN commented Oct 7, 2024

Pull request for issue #110823
Including the file which defines the macros we use here. This would let user code only include this interface, rather than having to include two files.

Copy link

github-actions bot commented Oct 7, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot
Copy link
Member

llvmbot commented Oct 7, 2024

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: None (gbMattN)

Changes

Pull request for issue #110823
Including the file which defines the macros we use here. This would let user code only include this interface, rather than having to include two files.


Full diff: https://github.com/llvm/llvm-project/pull/111374.diff

1 Files Affected:

  • (modified) compiler-rt/include/sanitizer/ubsan_interface.h (+2)
diff --git a/compiler-rt/include/sanitizer/ubsan_interface.h b/compiler-rt/include/sanitizer/ubsan_interface.h
index 435eb1ae332cad..30a7fd875043db 100644
--- a/compiler-rt/include/sanitizer/ubsan_interface.h
+++ b/compiler-rt/include/sanitizer/ubsan_interface.h
@@ -13,6 +13,8 @@
 #ifndef SANITIZER_UBSAN_INTERFACE_H
 #define SANITIZER_UBSAN_INTERFACE_H
 
+#include <sanitizer/common_interface_defs.h>
+
 #ifdef __cplusplus
 extern "C" {
 #endif

@gbMattN
Copy link
Contributor Author

gbMattN commented Oct 7, 2024

@kcc

Copy link
Contributor

@fmayer fmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fmayer fmayer merged commit 75103aa into llvm:main Oct 7, 2024
12 checks passed
Copy link

github-actions bot commented Oct 7, 2024

@gbMattN Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@gbMattN gbMattN deleted the users/nagym/add-missing-include-in-ubsan_interface.h branch January 20, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants