[LLVM][DOCS] Add documentation for 'host' and 'Native' options in LLVM_TARGETS_TO_BUILD. #111382

harrisonGPU · 2024-10-07T14:05:57Z

From #111356

…M_TARGETS_TO_BUILD.

llvm/docs/CMake.rst

harrisonGPU · 2024-10-07T14:33:39Z

Hello, @nikic , I have already updated it, please take a look agagin. :)

PerMildner · 2024-10-07T14:44:55Z

Not mentioned in the issue, but the value all is apparently also one of the "symbolic" values, so perhaps that too should be explicitly mentioned.

harrisonGPU · 2024-10-07T14:51:32Z

Not mentioned in the issue, but the value all is apparently also one of the "symbolic" values, so perhaps that too should be explicitly mentioned.

Okay, I have already updated it. :)

MaskRay · 2024-10-07T16:41:48Z

llvm/docs/CMake.rst

@@ -836,6 +836,12 @@ enabled sub-projects. Nearly all of these variable names begin with
  The full list, as of March 2023, is:
  ``AArch64;AMDGPU;ARM;AVR;BPF;Hexagon;Lanai;LoongArch;Mips;MSP430;NVPTX;PowerPC;RISCV;Sparc;SystemZ;VE;WebAssembly;X86;XCore``

+  You can also specify ``host`` or ``Native`` to automatically detect and


Just document the common host and omit Native?

It is good to only promote one canonical symbolic name, e.g. host. However, for someone reading the documentation for understanding some project found on the net, it is really important that all accepted names are documented.

Okay, thanks.

harrisonGPU · 2024-10-08T04:03:15Z

@MaskRay , Could you please help me merge this PR? Now I have not merge access right. :）

MaskRay · 2024-10-08T04:53:58Z

Other reviewers have commented. We leave the PR open for a while

RKSimon

LGTM

nikic · 2024-10-09T13:27:03Z

llvm/docs/CMake.rst

@@ -836,6 +836,12 @@ enabled sub-projects. Nearly all of these variable names begin with
  The full list, as of March 2023, is:
  ``AArch64;AMDGPU;ARM;AVR;BPF;Hexagon;Lanai;LoongArch;Mips;MSP430;NVPTX;PowerPC;RISCV;Sparc;SystemZ;VE;WebAssembly;X86;XCore``

+  You can also specify ``host`` or ``Native`` to automatically detect and
+  include the target corresponding to the host machine's architecture, or
+  use ``all`` to include all available targets.


Note that all is already mentioned above (in the part that github helpfully hides by default).

Okay, thanks!

harrisonGPU · 2024-10-10T12:45:36Z

Thanks！

llvm-ci · 2024-10-10T13:02:15Z

LLVM Buildbot has detected a new failure on builder openmp-offload-libc-amdgpu-runtime running on omp-vega20-1 while building llvm at step 10 "Add check check-offload".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/6863

Here is the relevant piece of the build log for the reference

Step 10 (Add check check-offload) failure: test (failure)
******************** TEST 'libomptarget :: amdgcn-amd-amdhsa :: sanitizer/ptr_outside_alloc_2.c' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 2
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/clang -fopenmp    -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/offload/test -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -L /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload -L /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./lib -L /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src  -nogpulib -Wl,-rpath,/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload -Wl,-rpath,/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./lib  -fopenmp-targets=amdgcn-amd-amdhsa -O3 /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/offload/test/sanitizer/ptr_outside_alloc_2.c -o /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload/test/amdgcn-amd-amdhsa/sanitizer/Output/ptr_outside_alloc_2.c.tmp -Xoffload-linker -lc -Xoffload-linker -lm /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./lib/libomptarget.devicertl.a
# executed command: /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/clang -fopenmp -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/offload/test -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -L /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload -L /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./lib -L /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -nogpulib -Wl,-rpath,/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload -Wl,-rpath,/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./lib -fopenmp-targets=amdgcn-amd-amdhsa -O3 /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/offload/test/sanitizer/ptr_outside_alloc_2.c -o /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload/test/amdgcn-amd-amdhsa/sanitizer/Output/ptr_outside_alloc_2.c.tmp -Xoffload-linker -lc -Xoffload-linker -lm /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./lib/libomptarget.devicertl.a
# RUN: at line 3
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/not --crash env -u LLVM_DISABLE_SYMBOLIZATION OFFLOAD_TRACK_ALLOCATION_TRACES=1 /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload/test/amdgcn-amd-amdhsa/sanitizer/Output/ptr_outside_alloc_2.c.tmp 2>&1 | /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/FileCheck /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/offload/test/sanitizer/ptr_outside_alloc_2.c --check-prefixes=CHECK
# executed command: /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/not --crash env -u LLVM_DISABLE_SYMBOLIZATION OFFLOAD_TRACK_ALLOCATION_TRACES=1 /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload/test/amdgcn-amd-amdhsa/sanitizer/Output/ptr_outside_alloc_2.c.tmp
# executed command: /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/FileCheck /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/offload/test/sanitizer/ptr_outside_alloc_2.c --check-prefixes=CHECK
# .---command stderr------------
# | /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/offload/test/sanitizer/ptr_outside_alloc_2.c:21:11: error: CHECK: expected string not found in input
# | // CHECK: OFFLOAD ERROR: Memory access fault by GPU {{.*}} (agent 0x{{.*}}) at virtual address [[PTR:0x[0-9a-z]*]]. Reasons: {{.*}}
# |           ^
# | <stdin>:1:1: note: scanning from here
# | AMDGPU error: Error in hsa_amd_memory_pool_allocate: HSA_STATUS_ERROR_OUT_OF_RESOURCES: The runtime failed to allocate the necessary resources. This error may also occur when the core runtime library needs to spawn threads or create internal OS-specific events.
# | ^
# | 
# | Input file: <stdin>
# | Check file: /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/offload/test/sanitizer/ptr_outside_alloc_2.c
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |           1: AMDGPU error: Error in hsa_amd_memory_pool_allocate: HSA_STATUS_ERROR_OUT_OF_RESOURCES: The runtime failed to allocate the necessary resources. This error may also occur when the core runtime library needs to spawn threads or create internal OS-specific events. 
# | check:21     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
# |           2: AMDGPU error: Error in hsa_amd_memory_pool_allocate: HSA_STATUS_ERROR_OUT_OF_RESOURCES: The runtime failed to allocate the necessary resources. This error may also occur when the core runtime library needs to spawn threads or create internal OS-specific events. 
# | check:21     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           3: "PluginInterface" error: Failure to allocate device memory: Failed to allocate from memory manager 
# | check:21     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           4: omptarget error: Call to getTargetPointer returned null pointer (device failure or illegal mapping). 
# | check:21     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           5: omptarget error: Call to targetDataBegin failed, abort target. 
# | check:21     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           6: omptarget error: Failed to process data before launching the kernel. 
# | check:21     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           .
# |           .
# |           .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

********************

PerMildner · 2024-10-10T20:34:12Z

Thanks all for the speedy fix!

…M_TARGETS_TO_BUILD. (llvm#111382) From llvm#111356

harrisonGPU mentioned this pull request Oct 7, 2024

LLVM_TARGETS_TO_BUILD incomplete documentation (missing "host", "Native") #111356

Closed

[LLVM][DOCS] Add documentation for 'host' and 'Native' options in LLV…

90e97b6

…M_TARGETS_TO_BUILD.

harrisonGPU force-pushed the harrison/llvm/doc branch from f0fe4aa to 90e97b6 Compare October 7, 2024 14:14

dtcxzyw requested review from nikic, MaskRay, RKSimon and topperc October 7, 2024 14:15

nikic reviewed Oct 7, 2024

View reviewed changes

llvm/docs/CMake.rst Outdated Show resolved Hide resolved

llvm/docs/CMake.rst Outdated Show resolved Hide resolved

llvm/docs/CMake.rst Outdated Show resolved Hide resolved

[DOCS] Update for comments.

4fb7d22

harrisonGPU force-pushed the harrison/llvm/doc branch from 8ea74b3 to 4fb7d22 Compare October 7, 2024 14:38

harrisonGPU requested a review from nikic October 7, 2024 14:39

[DOCS] Add 'all' target comments.

52519ba

MaskRay approved these changes Oct 7, 2024

View reviewed changes

harrisonGPU added 2 commits October 8, 2024 08:48

Merge branch 'main' into harrison/llvm/doc

fb17779

Merge branch 'main' into harrison/llvm/doc

56a1346

harrisonGPU requested a review from MaskRay October 8, 2024 04:04

RKSimon approved these changes Oct 9, 2024

View reviewed changes

nikic reviewed Oct 9, 2024

View reviewed changes

harrisonGPU merged commit 36a0d44 into llvm:main Oct 10, 2024
9 checks passed

harrisonGPU deleted the harrison/llvm/doc branch October 10, 2024 12:58

DanielCChen pushed a commit to DanielCChen/llvm-project that referenced this pull request Oct 16, 2024

[LLVM][DOCS] Add documentation for 'host' and 'Native' options in LLV…

3d12671

…M_TARGETS_TO_BUILD. (llvm#111382) From llvm#111356

[LLVM][DOCS] Add documentation for 'host' and 'Native' options in LLVM_TARGETS_TO_BUILD. #111382

[LLVM][DOCS] Add documentation for 'host' and 'Native' options in LLVM_TARGETS_TO_BUILD. #111382

Uh oh!

Conversation

harrisonGPU commented Oct 7, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

harrisonGPU commented Oct 7, 2024

Uh oh!

PerMildner commented Oct 7, 2024

Uh oh!

harrisonGPU commented Oct 7, 2024

Uh oh!

MaskRay Oct 7, 2024

Choose a reason for hiding this comment

Uh oh!

PerMildner Oct 7, 2024

Choose a reason for hiding this comment

Uh oh!

harrisonGPU Oct 8, 2024

Choose a reason for hiding this comment

Uh oh!

harrisonGPU commented Oct 8, 2024

Uh oh!

MaskRay commented Oct 8, 2024

Uh oh!

RKSimon left a comment

Choose a reason for hiding this comment

Uh oh!

nikic Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

harrisonGPU Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

harrisonGPU commented Oct 10, 2024

Uh oh!

Uh oh!

llvm-ci commented Oct 10, 2024

Uh oh!

PerMildner commented Oct 10, 2024

Uh oh!

Uh oh!