Skip to content

[libomp][AIX] Use SO version "1" for AIX libomp #111384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

xingxue-ibm
Copy link
Contributor

For libomp on AIX, we build shared object libomp.so first and then archive it into libomp.a. This patch changes to use SO version 1 and name the shared object libomp.so.1 so that it is consistent with the naming of other shared objects in AIX libraries, e.g., libc++.so.1 in libc++.a. With this change, the change made in commit bde51d9 to ensure only libomp.a is published on AIX is no longer necessary and is removed.

@xingxue-ibm xingxue-ibm added the openmp:libomp OpenMP host runtime label Oct 7, 2024
@xingxue-ibm xingxue-ibm self-assigned this Oct 7, 2024
Copy link
Contributor

@DanielCChen DanielCChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingxue-ibm xingxue-ibm merged commit c62e61a into llvm:main Oct 8, 2024
9 checks passed
@xingxue-ibm xingxue-ibm deleted the libomp-so-name branch April 1, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomp OpenMP host runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants