Skip to content

[rtsan][compiler-rt] Get rid of [[blocking]] stub in tests #111392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2024
Merged

[rtsan][compiler-rt] Get rid of [[blocking]] stub in tests #111392

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8bc15b
[rtsan][compiler-rt] Get rid of [[blocking]] stub in tests
cjappl Oct 7, 2024
c594208
[PR] dtraev - Clean up fn names
cjappl Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 14 additions & 19 deletions compiler-rt/test/rtsan/blocking_call.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,28 +7,23 @@
#include <stdio.h>
#include <stdlib.h>

// TODO: Remove when [[blocking]] is implemented.
extern "C" void __rtsan_notify_blocking_call(const char *function_name);

void custom_blocking_function() {
// TODO: When [[blocking]] is implemented, don't call this directly.
__rtsan_notify_blocking_call(__func__);
}

void safe_call() {
// TODO: When [[blocking]] is implemented, don't call this directly.
__rtsan_notify_blocking_call(__func__);
void custom_blocking_function() [[clang::blocking]] {
printf("In blocking function\n");
}

void process() [[clang::nonblocking]] { custom_blocking_function(); }
void realtime_function() [[clang::nonblocking]] { custom_blocking_function(); }
void nonrealtime_function() { custom_blocking_function(); }

int main() {
safe_call(); // This shouldn't die, because it isn't in nonblocking context.
process();
nonrealtime_function();
realtime_function();
return 0;
// CHECK-NOT: {{.*safe_call*}}
// CHECK: ==ERROR: RealtimeSanitizer: blocking-call
// CHECK-NEXT: Call to blocking function `custom_blocking_function` in real-time context!
// CHECK-NEXT: {{.*custom_blocking_function*}}
// CHECK-NEXT: {{.*process*}}
}

// CHECK: ==ERROR: RealtimeSanitizer: blocking-call
// CHECK-NEXT: Call to blocking function `custom_blocking_function()` in real-time context!
// CHECK-NEXT: {{.*custom_blocking_function*}}
// CHECK-NEXT: {{.*realtime_function*}}

// should only occur once
// CHECK-NOT: ==ERROR: RealtimeSanitizer: blocking-call
Loading